[openwrt/openwrt] realtek: dsa: Simplify rtl83xx_setup_qos
LEDE Commits
lede-commits at lists.infradead.org
Thu Nov 6 01:34:13 PST 2025
noltari pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/4ed96e54cd811c50ce1f5ef7d074fccc9d6a54a5
commit 4ed96e54cd811c50ce1f5ef7d074fccc9d6a54a5
Author: Sven Eckelmann <se at simonwunderlich.de>
AuthorDate: Tue Nov 4 12:14:58 2025 +0100
realtek: dsa: Simplify rtl83xx_setup_qos
It is not necessary to have two different family_id checks directly after
another. It is simpler to just combine both into one.
Suggested-by: Álvaro Fernández Rojas <noltari at gmail.com>
Signed-off-by: Sven Eckelmann <se at simonwunderlich.de>
Link: https://github.com/openwrt/openwrt/pull/20637
Signed-off-by: Álvaro Fernández Rojas <noltari at gmail.com>
---
.../linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/qos.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/qos.c b/target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/qos.c
index 55145b5fcf..4794ea9576 100644
--- a/target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/qos.c
+++ b/target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/qos.c
@@ -553,13 +553,14 @@ void __init rtl83xx_setup_qos(struct rtl838x_switch_priv *priv)
pr_info("In %s\n", __func__);
- if (priv->family_id == RTL8380_FAMILY_ID)
+ switch (priv->family_id) {
+ case RTL8380_FAMILY_ID:
rtl838x_config_qos();
- else if (priv->family_id == RTL8390_FAMILY_ID)
- rtl839x_config_qos();
-
- if (priv->family_id == RTL8380_FAMILY_ID)
rtl838x_rate_control_init(priv);
- else if (priv->family_id == RTL8390_FAMILY_ID)
+ break;
+ case RTL8390_FAMILY_ID:
+ rtl839x_config_qos();
rtl839x_rate_control_init(priv);
+ break;
+ }
}
More information about the lede-commits
mailing list