[openwrt/openwrt] realtek: align declaration/static/extern function definitions for clock driver
LEDE Commits
lede-commits at lists.infradead.org
Tue May 27 01:26:51 PDT 2025
robimarko pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/31e2567164f66ce96dba6fae3739eb1a55bd1283
commit 31e2567164f66ce96dba6fae3739eb1a55bd1283
Author: Markus Stockhausen <markus.stockhausen at gmx.de>
AuthorDate: Mon May 26 08:13:29 2025 -0400
realtek: align declaration/static/extern function definitions for clock driver
In 2023 upstream has tightened compiler checks with this patch
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit
/scripts/Makefile.extrawarn?h=v6.15&id=0fcb70851fbfea1776ae62f67c503fef8f0292b9
A consistent function definition is now needed. I.e.
- functions must be either declared with "static" or
- functions need an additional declaration (in the header file)
Before upgrading the Realtek target to 6.12 clean the code so that the main
6.12 PR can focus on real issues from the version bump.
Signed-off-by: Markus Stockhausen <markus.stockhausen at gmx.de>
Link: https://github.com/openwrt/openwrt/pull/18925
Signed-off-by: Robert Marko <robimarko at gmail.com>
---
target/linux/realtek/files-6.6/drivers/clk/realtek/clk-rtl83xx.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/target/linux/realtek/files-6.6/drivers/clk/realtek/clk-rtl83xx.c b/target/linux/realtek/files-6.6/drivers/clk/realtek/clk-rtl83xx.c
index 0cca32ab34..bdec59830d 100644
--- a/target/linux/realtek/files-6.6/drivers/clk/realtek/clk-rtl83xx.c
+++ b/target/linux/realtek/files-6.6/drivers/clk/realtek/clk-rtl83xx.c
@@ -504,7 +504,7 @@ static int rtcl_ccu_create(struct device_node *np)
return 0;
}
-int rtcl_register_clkhw(int clk_idx)
+static int rtcl_register_clkhw(int clk_idx)
{
int ret;
struct clk *clk;
@@ -592,7 +592,7 @@ err_hw_unregister:
return ret;
}
-int rtcl_init_sram(void)
+static int rtcl_init_sram(void)
{
struct gen_pool *sram_pool;
phys_addr_t sram_pbase;
@@ -665,7 +665,7 @@ err_put_device:
return -ENXIO;
}
-void rtcl_ccu_log_early(void)
+static void rtcl_ccu_log_early(void)
{
char meminfo[80], clkinfo[255], msg[255] = "rtl83xx-clk: initialized";
@@ -680,7 +680,7 @@ void rtcl_ccu_log_early(void)
pr_info("%s\n", msg);
}
-void rtcl_ccu_log_late(void)
+static void rtcl_ccu_log_late(void)
{
struct rtcl_clk *rclk;
bool overclock = false;
More information about the lede-commits
mailing list