[openwrt/openwrt] qualcommax: ipq50xx: remove ECC user config from board files

LEDE Commits lede-commits at lists.infradead.org
Thu May 8 06:40:14 PDT 2025


robimarko pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/01b72ce61e8f7d050785981ab83d059e6cba4c27

commit 01b72ce61e8f7d050785981ab83d059e6cba4c27
Author: George Moussalem <george.moussalem at outlook.com>
AuthorDate: Tue May 6 10:18:09 2025 +0400

    qualcommax: ipq50xx: remove ECC user config from board files
    
    With the spi-qpic-snand driver now supporting reading ECC requirements
    from the NAND chip itself, there's no need to set those in the DTS
    anymore avoiding issues with devices of the same revision using
    different NAND types with varying ECC requirements.
    
    Signed-off-by: George Moussalem <george.moussalem at outlook.com>
    Link: https://github.com/openwrt/openwrt/pull/18723
    Signed-off-by: Robert Marko <robimarko at gmail.com>
---
 .../qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-gl-b3000.dts  | 2 --
 .../qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-mr5500.dts    | 6 ------
 .../qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-mx-base.dtsi  | 3 ---
 .../files/arch/arm64/boot/dts/qcom/ipq5018-wrc-x3000gs2.dts         | 4 ----
 4 files changed, 15 deletions(-)

diff --git a/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-gl-b3000.dts b/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-gl-b3000.dts
index 684b6d95c5..9abf20fec5 100644
--- a/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-gl-b3000.dts
+++ b/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-gl-b3000.dts
@@ -226,8 +226,6 @@
 		#size-cells = <1>;
 
 		nand-ecc-engine = <&qpic_nand>;
-		nand-ecc-strength = <4>;
-		nand-ecc-step-size = <512>;
 		nand-bus-width = <8>;
 
 		partitions {
diff --git a/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-mr5500.dts b/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-mr5500.dts
index 8dbd8a5d88..99bd9a71a2 100644
--- a/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-mr5500.dts
+++ b/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-mr5500.dts
@@ -28,12 +28,6 @@
 	};
 };
 
-&qpic_nand {
-	nand at 0 {
-		nand-ecc-strength = <4>;
-	};
-};
-
 /*
  * ===============================================================
  *     _______________________         _______________________
diff --git a/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-mx-base.dtsi b/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-mx-base.dtsi
index a015fcbd34..0cc70cceb7 100644
--- a/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-mx-base.dtsi
+++ b/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-mx-base.dtsi
@@ -130,9 +130,6 @@
 		#size-cells = <1>;
 
 		nand-ecc-engine = <&qpic_nand>;
-
-		nand-ecc-strength = <8>;
-		nand-ecc-step-size = <512>;
 		nand-bus-width = <8>;
 
 		partitions {
diff --git a/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-wrc-x3000gs2.dts b/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-wrc-x3000gs2.dts
index fc3e86b870..69f124cb9d 100644
--- a/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-wrc-x3000gs2.dts
+++ b/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq5018-wrc-x3000gs2.dts
@@ -164,10 +164,6 @@
 		#size-cells = <1>;
 
 		nand-ecc-engine = <&qpic_nand>;
-
-		/* strength=8 breaks NAND I/O, use 4 instead */
-		nand-ecc-strength = <4>;
-		nand-ecc-step-size = <512>;
 		nand-bus-width = <8>;
 
 		partitions {




More information about the lede-commits mailing list