[openwrt/openwrt] uboot-mediatek: u7623: remove keys pin function

LEDE Commits lede-commits at lists.infradead.org
Mon Mar 17 08:22:59 PDT 2025


hauke pushed a commit to openwrt/openwrt.git, branch openwrt-24.10:
https://git.openwrt.org/82fabe43709da2d7f744e8e05ab19317420c8063

commit 82fabe43709da2d7f744e8e05ab19317420c8063
Author: Tomasz Maciej Nowak <tmn505 at gmail.com>
AuthorDate: Tue Mar 4 17:43:10 2025 +0100

    uboot-mediatek: u7623: remove keys pin function
    
    Apparently U-Boot will discard whole node if requested pin function is
    unknown to the driver. This resulted in inability to interact with
    U-Boot on the said board, as U-Boot always assumed the recovery key
    pressed and issued recovery procedure. Log snippet:
    
    button_gpio gpio-keys: pinctrl_select_state_full: pinctrl_config_one: err=-38
    reset button found
    button pushed, resetting environment
    
    Recovery procedure also booted recovery image, which didn't affect much
    the 23.05.x release, since the root fs argument was valid, so changes
    persisted. But as 24.10.x hit with fitblk, the board will boot only
    recovery image (initramfs) because of default bootargs will reset on each
    boot and U-Boot provided bootargs took precedence.
    
    Fixes: 42eeb22450f2 ("uboot-mediatek: fix factory/reset button")
    Signed-off-by: Tomasz Maciej Nowak <tmn505 at gmail.com>
    Link: https://patchwork.ozlabs.org/project/openwrt/patch/20250304164507.60511-1-tmn505@terefe.re/
    Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de>
    (cherry picked from commit f8a2e1c68b48d72234172543f4232e77f065ca4d)
---
 package/boot/uboot-mediatek/patches/401-update-u7623-defconfig.patch | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/package/boot/uboot-mediatek/patches/401-update-u7623-defconfig.patch b/package/boot/uboot-mediatek/patches/401-update-u7623-defconfig.patch
index 1fb0ae9c9e..7d19369672 100644
--- a/package/boot/uboot-mediatek/patches/401-update-u7623-defconfig.patch
+++ b/package/boot/uboot-mediatek/patches/401-update-u7623-defconfig.patch
@@ -187,13 +187,12 @@
  	leds {
  		compatible = "gpio-leds";
  
-@@ -109,6 +122,19 @@
+@@ -109,6 +122,18 @@
  		};
  	};
  
 +	key_pins_a: keys-alt {
 +		mux {
-+			function = "gpio";
 +			groups = "msdc3";
 +		};
 +




More information about the lede-commits mailing list