[openwrt/openwrt] cli: improve error handling on editor select call
LEDE Commits
lede-commits at lists.infradead.org
Sun Mar 9 01:55:07 PST 2025
nbd pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/7f0913d7b1fd15d911a23e1651263b6eb64c112a
commit 7f0913d7b1fd15d911a23e1651263b6eb64c112a
Author: Felix Fietkau <nbd at nbd.name>
AuthorDate: Sun Mar 9 10:49:52 2025 +0100
cli: improve error handling on editor select call
Use common error functions instead of explicit warn() calls
Signed-off-by: Felix Fietkau <nbd at nbd.name>
---
package/utils/cli/files/usr/share/ucode/cli/object-editor.uc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/utils/cli/files/usr/share/ucode/cli/object-editor.uc b/package/utils/cli/files/usr/share/ucode/cli/object-editor.uc
index 49e72f5c38..2a21e8d622 100644
--- a/package/utils/cli/files/usr/share/ucode/cli/object-editor.uc
+++ b/package/utils/cli/files/usr/share/ucode/cli/object-editor.uc
@@ -609,19 +609,19 @@ export function edit_create_destroy(info, node)
select: function(ctx, argv) {
let name = argv[0];
if (!name) {
- warn(`Missing argument\n`);
+ ctx.missing_argument();
return;
}
let obj = object_lookup(ctx, this, this.object_name);
if (!obj) {
- warn(`Object not found\n`);
+ ctx.invalid_argument("Object not found");
return;
}
let entry = obj[name];
if (!entry) {
- warn(`${name} not found\n`);
+ ctx.invalid_argument(`${name} not found: %s`, name);
return;
}
More information about the lede-commits
mailing list