[openwrt/openwrt] ucode-mod-pkgen: fix refcounting issue

LEDE Commits lede-commits at lists.infradead.org
Tue Mar 4 23:25:50 PST 2025


nbd pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/4d4e63126722ab6b56add10d39c4ecbd5edfbd1c

commit 4d4e63126722ab6b56add10d39c4ecbd5edfbd1c
Author: Felix Fietkau <nbd at nbd.name>
AuthorDate: Wed Mar 5 08:24:01 2025 +0100

    ucode-mod-pkgen: fix refcounting issue
    
    Do not call ucv_get if the reference is transferred without being used
    elsewhere
    
    Signed-off-by: Felix Fietkau <nbd at nbd.name>
---
 package/utils/ucode-mod-pkgen/src/ucode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/utils/ucode-mod-pkgen/src/ucode.c b/package/utils/ucode-mod-pkgen/src/ucode.c
index cb5569b977..4b7779f136 100644
--- a/package/utils/ucode-mod-pkgen/src/ucode.c
+++ b/package/utils/ucode-mod-pkgen/src/ucode.c
@@ -269,7 +269,7 @@ uc_cert_info(uc_vm_t *vm, size_t nargs)
 		uc_value_t *info = ucv_object_new(vm);
 		int len;
 
-		ucv_array_push(ret, ucv_get(info));
+		ucv_array_push(ret, info);
 		ucv_object_add(info, "version", ucv_int64_new(cur->version));
 
 		uc_cert_info_add_name(info, "issuer", &cur->issuer);




More information about the lede-commits mailing list