[openwrt/openwrt] omnia-eeprom: simplify Makefile

LEDE Commits lede-commits at lists.infradead.org
Sun Jun 22 10:02:27 PDT 2025


hauke pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/e7044dce96b460b44288b1c056564e0da6d80039

commit e7044dce96b460b44288b1c056564e0da6d80039
Author: Josef Schlehofer <pepe.schlehofer at gmail.com>
AuthorDate: Wed Jun 11 22:56:54 2025 +0200

    omnia-eeprom: simplify Makefile
    
    1. No need to explicitly call the defaults
    2. There is efficient way how to set PKG_BUILD_DIR,
    which allows to drop PKG_SOURCE_DIR.
    
    Signed-off-by: Josef Schlehofer <pepe.schlehofer at gmail.com>
    Link: https://github.com/openwrt/openwrt/pull/19105
    Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de>
---
 package/utils/omnia-eeprom/Makefile | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/package/utils/omnia-eeprom/Makefile b/package/utils/omnia-eeprom/Makefile
index 9418e93f44..44108c0cb4 100644
--- a/package/utils/omnia-eeprom/Makefile
+++ b/package/utils/omnia-eeprom/Makefile
@@ -11,7 +11,6 @@ PKG_NAME:=omnia-eeprom
 PKG_VERSION:=0.1
 PKG_RELEASE:=1
 
-PKG_SOURCE_SUBDIR:=$(PKG_NAME)-v$(PKG_VERSION)
 PKG_SOURCE:=$(PKG_NAME)-v$(PKG_VERSION).tar.bz2
 PKG_SOURCE_URL:=https://gitlab.nic.cz/turris/omnia-eeprom/-/archive/v$(PKG_VERSION)/
 PKG_HASH:=6f949d0b8080adca8bae088774ce615b563ba6ec2807cce97ee6769b4eee7bbf
@@ -19,8 +18,7 @@ PKG_FLAGS:=nonshared
 
 PKG_MAINTAINER:=Marek Behun <kabel at kernel.org>
 PKG_LICENSE:=GPL-2.0-or-later
-
-PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_SOURCE_SUBDIR)
+PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME)-v$(PKG_VERSION)
 
 include $(INCLUDE_DIR)/package.mk
 
@@ -44,11 +42,8 @@ the DDR training algorithm).
 endef
 
 MAKE_VARS += OMNIA_EEPROM_VERSION="v$(PKG_VERSION)"
-
 TARGET_CFLAGS += -Wall
 
-Build/Compile = $(Build/Compile/Default)
-
 define Package/omnia-eeprom/install
 	$(INSTALL_DIR) $(1)/usr/bin
 	$(INSTALL_BIN) $(PKG_BUILD_DIR)/omnia-eeprom $(1)/usr/bin/




More information about the lede-commits mailing list