[openwrt/openwrt] ramips: mtk-sd: stability improvements for MIPS mt762x SoCs
LEDE Commits
lede-commits at lists.infradead.org
Mon Jun 16 10:33:25 PDT 2025
hauke pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/3f78e5c918000faeef2f827333680a708df94ca9
commit 3f78e5c918000faeef2f827333680a708df94ca9
Author: Shiji Yang <yangshiji66 at outlook.com>
AuthorDate: Fri Jun 13 21:36:16 2025 +0800
ramips: mtk-sd: stability improvements for MIPS mt762x SoCs
* Add tuning parameters to improve the stability of 48~50 MHz
High-Speed SD mode.
* Fix I/O errors on EMMC mode by disabling unsupported auto CMD23
feature.
Signed-off-by: Shiji Yang <yangshiji66 at outlook.com>
Link: https://github.com/openwrt/openwrt/pull/18896
Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de>
---
...add-tuning-parameters-for-legacy-MIPS-MT7.patch | 81 ++++++++++++
...-sd-disable-auto-CMD23-support-for-mt7620.patch | 137 +++++++++++++++++++++
...use-default-PATCH_BIT1-2-values-for-mt762.patch | 30 +++++
...d-initialize-pad-delay-and-drive-strength.patch | 74 -----------
...add-tuning-parameters-for-legacy-MIPS-MT7.patch | 81 ++++++++++++
...-sd-disable-auto-CMD23-support-for-mt7620.patch | 137 +++++++++++++++++++++
...use-default-PATCH_BIT1-2-values-for-mt762.patch | 30 +++++
...d-initialize-pad-delay-and-drive-strength.patch | 74 -----------
8 files changed, 496 insertions(+), 148 deletions(-)
diff --git a/target/linux/ramips/patches-6.12/831-01-mmc-mtk-sd-add-tuning-parameters-for-legacy-MIPS-MT7.patch b/target/linux/ramips/patches-6.12/831-01-mmc-mtk-sd-add-tuning-parameters-for-legacy-MIPS-MT7.patch
new file mode 100644
index 0000000000..328ff20ab9
--- /dev/null
+++ b/target/linux/ramips/patches-6.12/831-01-mmc-mtk-sd-add-tuning-parameters-for-legacy-MIPS-MT7.patch
@@ -0,0 +1,81 @@
+From: Shiji Yang <yangshiji66 at outlook.com>
+Date: Sat, 24 May 2025 15:53:26 +0800
+Subject: [PATCH 1/3] mmc: mtk-sd: add tuning parameters for legacy MIPS MT762x
+ SoCs
+
+The MIPS MT762x SoCs require some specific tuning parameters at
+different clock frequencies. These legacy SoCs only support max
+48~50 MHz High-Speed SD mode. Therefore, the standard tuning step
+is not available. We have to hard code these tuning parameters
+to make them work properly.
+
+Signed-off-by: Shiji Yang <yangshiji66 at outlook.com>
+---
+ drivers/mmc/host/mtk-sd.c | 26 +++++++++++++++++++++++++-
+ 1 file changed, 25 insertions(+), 1 deletion(-)
+
+--- a/drivers/mmc/host/mtk-sd.c
++++ b/drivers/mmc/host/mtk-sd.c
+@@ -75,8 +75,13 @@
+ #define MSDC_PATCH_BIT 0xb0
+ #define MSDC_PATCH_BIT1 0xb4
+ #define MSDC_PATCH_BIT2 0xb8
++#define MSDC_PAD_CTRL0 0xe0
++#define MSDC_PAD_CTRL1 0xe4
++#define MSDC_PAD_CTRL2 0xe8
+ #define MSDC_PAD_TUNE 0xec
+ #define MSDC_PAD_TUNE0 0xf0
++#define MSDC_DAT_RDDLY0 0xf0
++#define MSDC_DAT_RDDLY1 0xf4
+ #define PAD_DS_TUNE 0x188
+ #define PAD_CMD_TUNE 0x18c
+ #define EMMC51_CFG0 0x204
+@@ -408,6 +413,7 @@ struct mtk_mmc_compatible {
+ bool enhance_rx;
+ bool support_64g;
+ bool use_internal_cd;
++ bool mips_mt762x;
+ };
+
+ struct msdc_tune_para {
+@@ -547,6 +553,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = false,
+ .enhance_rx = false,
+ .use_internal_cd = true,
++ .mips_mt762x = true,
+ };
+
+ static const struct mtk_mmc_compatible mt7622_compat = {
+@@ -969,7 +976,12 @@ static void msdc_set_mclk(struct msdc_ho
+ * mmc_select_hs400() will drop to 50Mhz and High speed mode,
+ * tune result of hs200/200Mhz is not suitable for 50Mhz
+ */
+- if (mmc->actual_clock <= 52000000) {
++ if (host->dev_comp->mips_mt762x &&
++ mmc->actual_clock > 25000000) {
++ sdr_set_bits(host->base + MSDC_IOCON, MSDC_IOCON_RSPL);
++ sdr_set_bits(host->base + MSDC_IOCON, MSDC_IOCON_DSPL);
++ sdr_set_bits(host->base + MSDC_IOCON, MSDC_IOCON_W_DSPL);
++ } else if (mmc->actual_clock <= 52000000) {
+ writel(host->def_tune_para.iocon, host->base + MSDC_IOCON);
+ if (host->top_base) {
+ writel(host->def_tune_para.emmc_top_control,
+@@ -1839,6 +1851,18 @@ static void msdc_init_hw(struct msdc_hos
+ MSDC_PAD_TUNE_RXDLYSEL);
+ }
+
++ if (host->dev_comp->mips_mt762x) {
++ /* Set pins drive strength */
++ writel(0x000d0044, host->base + MSDC_PAD_CTRL0);
++ writel(0x000e0044, host->base + MSDC_PAD_CTRL1);
++ writel(0x000e0044, host->base + MSDC_PAD_CTRL2);
++
++ /* Set tuning parameters */
++ writel(0x84101010, host->base + tune_reg);
++ writel(0x10101010, host->base + MSDC_DAT_RDDLY0);
++ writel(0x10101010, host->base + MSDC_DAT_RDDLY1);
++ }
++
+ if (mmc->caps2 & MMC_CAP2_NO_SDIO) {
+ sdr_clr_bits(host->base + SDC_CFG, SDC_CFG_SDIO);
+ sdr_clr_bits(host->base + MSDC_INTEN, MSDC_INTEN_SDIOIRQ);
diff --git a/target/linux/ramips/patches-6.12/831-02-mmc-mtk-sd-disable-auto-CMD23-support-for-mt7620.patch b/target/linux/ramips/patches-6.12/831-02-mmc-mtk-sd-disable-auto-CMD23-support-for-mt7620.patch
new file mode 100644
index 0000000000..93790b551d
--- /dev/null
+++ b/target/linux/ramips/patches-6.12/831-02-mmc-mtk-sd-disable-auto-CMD23-support-for-mt7620.patch
@@ -0,0 +1,137 @@
+From: Shiji Yang <yangshiji66 at outlook.com>
+Date: Fri, 13 Jun 2025 20:12:55 +0800
+Subject: [PATCH 2/3] mmc: mtk-sd: disable auto CMD23 support for mt7620
+
+MT7628 ProgrammingGuide indicates that the host controller version
+3.0 and later support auto CMD23 function. However, it doesn't
+define SD command register BIT[29](Auto CMD23 enable bit). I guess
+the legacy MIPS MT762x series SoCs don't support this feature at
+all. The experiment on JDCloud RE-SP-01B(MT7621 + 128 GiB EMMC)
+shows that disabling auto CMD23 can fix the following IO errors:
+
+[ 143.344604] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002
+[ 143.353661] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002
+[ 143.362662] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002
+[ 143.371684] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002
+[ 143.380684] I/O error, dev mmcblk0boot0, sector 0 op 0x0:(READ) flags 0x80700 phys_seg 4 prio class 0
+[ 143.390414] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002
+[ 143.399468] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002
+[ 143.408516] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002
+[ 143.417556] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002
+[ 143.426590] I/O error, dev mmcblk0boot0, sector 0 op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0
+[ 143.435585] Buffer I/O error on dev mmcblk0boot0, logical block 0, async page read
+
+Signed-off-by: Shiji Yang <yangshiji66 at outlook.com>
+---
+ drivers/mmc/host/mtk-sd.c | 16 +++++++++++++++-
+ 1 file changed, 15 insertions(+), 1 deletion(-)
+
+--- a/drivers/mmc/host/mtk-sd.c
++++ b/drivers/mmc/host/mtk-sd.c
+@@ -412,6 +412,7 @@ struct mtk_mmc_compatible {
+ bool stop_clk_fix;
+ bool enhance_rx;
+ bool support_64g;
++ bool support_cmd23;
+ bool use_internal_cd;
+ bool mips_mt762x;
+ };
+@@ -501,6 +502,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = false,
+ .enhance_rx = false,
+ .support_64g = false,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt2712_compat = {
+@@ -514,6 +516,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = true,
+ .enhance_rx = true,
+ .support_64g = true,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt6779_compat = {
+@@ -527,6 +530,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = true,
+ .enhance_rx = true,
+ .support_64g = true,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt6795_compat = {
+@@ -540,6 +544,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = false,
+ .enhance_rx = false,
+ .support_64g = false,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt7620_compat = {
+@@ -552,6 +557,7 @@ static const struct mtk_mmc_compatible m
+ .busy_check = false,
+ .stop_clk_fix = false,
+ .enhance_rx = false,
++ .support_cmd23 = false,
+ .use_internal_cd = true,
+ .mips_mt762x = true,
+ };
+@@ -567,6 +573,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = true,
+ .enhance_rx = true,
+ .support_64g = false,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt7986_compat = {
+@@ -580,6 +587,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = true,
+ .enhance_rx = true,
+ .support_64g = true,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt8135_compat = {
+@@ -593,6 +601,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = false,
+ .enhance_rx = false,
+ .support_64g = false,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt8173_compat = {
+@@ -606,6 +615,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = false,
+ .enhance_rx = false,
+ .support_64g = false,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt8183_compat = {
+@@ -619,6 +629,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = true,
+ .enhance_rx = true,
+ .support_64g = true,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt8516_compat = {
+@@ -630,6 +641,7 @@ static const struct mtk_mmc_compatible m
+ .data_tune = true,
+ .busy_check = true,
+ .stop_clk_fix = true,
++ .support_cmd23 = true,
+ };
+
+ static const struct of_device_id msdc_of_ids[] = {
+@@ -2896,7 +2908,9 @@ static int msdc_drv_probe(struct platfor
+ if (mmc->caps & MMC_CAP_SDIO_IRQ)
+ mmc->caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD;
+
+- mmc->caps |= MMC_CAP_CMD23;
++ if (host->dev_comp->support_cmd23)
++ mmc->caps |= MMC_CAP_CMD23;
++
+ if (host->cqhci)
+ mmc->caps2 |= MMC_CAP2_CQE | MMC_CAP2_CQE_DCMD;
+ /* MMC core transfer sizes tunable parameters */
diff --git a/target/linux/ramips/patches-6.12/831-03-mmc-mtk-sd-use-default-PATCH_BIT1-2-values-for-mt762.patch b/target/linux/ramips/patches-6.12/831-03-mmc-mtk-sd-use-default-PATCH_BIT1-2-values-for-mt762.patch
new file mode 100644
index 0000000000..cfe43112a9
--- /dev/null
+++ b/target/linux/ramips/patches-6.12/831-03-mmc-mtk-sd-use-default-PATCH_BIT1-2-values-for-mt762.patch
@@ -0,0 +1,30 @@
+From: Shiji Yang <yangshiji66 at outlook.com>
+Date: Sat, 24 May 2025 15:53:26 +0800
+Subject: [PATCH 3/3] mmc: mtk-sd: use default PATCH_BIT1/2 values for mt7620
+
+The definitions of these two registers seem to be slightly different
+from other variants. Use their default values to follow the vendor
+SDK driver behaviors.
+
+Signed-off-by: Shiji Yang <yangshiji66 at outlook.com>
+---
+ drivers/mmc/host/mtk-sd.c | 8 +++++---
+ 1 file changed, 5 insertions(+), 3 deletions(-)
+
+--- a/drivers/mmc/host/mtk-sd.c
++++ b/drivers/mmc/host/mtk-sd.c
+@@ -1787,9 +1787,11 @@ static void msdc_init_hw(struct msdc_hos
+ }
+ writel(0, host->base + MSDC_IOCON);
+ sdr_set_field(host->base + MSDC_IOCON, MSDC_IOCON_DDLSEL, 0);
+- writel(0x403c0046, host->base + MSDC_PATCH_BIT);
+- sdr_set_field(host->base + MSDC_PATCH_BIT, MSDC_CKGEN_MSDC_DLY_SEL, 1);
+- writel(0xffff4089, host->base + MSDC_PATCH_BIT1);
++ if (!host->dev_comp->mips_mt762x) {
++ writel(0x403c0046, host->base + MSDC_PATCH_BIT);
++ sdr_set_field(host->base + MSDC_PATCH_BIT, MSDC_CKGEN_MSDC_DLY_SEL, 1);
++ writel(0xffff4089, host->base + MSDC_PATCH_BIT1);
++ }
+ sdr_set_bits(host->base + EMMC50_CFG0, EMMC50_CFG_CFCSTS_SEL);
+
+ if (host->dev_comp->stop_clk_fix) {
diff --git a/target/linux/ramips/patches-6.12/831-mmc-mtk-sd-initialize-pad-delay-and-drive-strength.patch b/target/linux/ramips/patches-6.12/831-mmc-mtk-sd-initialize-pad-delay-and-drive-strength.patch
deleted file mode 100644
index a1e92560c1..0000000000
--- a/target/linux/ramips/patches-6.12/831-mmc-mtk-sd-initialize-pad-delay-and-drive-strength.patch
+++ /dev/null
@@ -1,74 +0,0 @@
-From: Shiji Yang <yangshiji66 at outlook.com>
-Date: Wed, 10 Jul 2024 12:18:52 +0800
-Subject: [PATCH] mmc: mtk-sd: initialize the pad and tune registers
-
-Signed-off-by: Shiji Yang <yangshiji66 at outlook.com>
----
- drivers/mmc/host/mtk-sd.c | 26 +++++++++++++++++++++++---
- 1 file changed, 23 insertions(+), 3 deletions(-)
-
---- a/drivers/mmc/host/mtk-sd.c
-+++ b/drivers/mmc/host/mtk-sd.c
-@@ -75,8 +75,12 @@
- #define MSDC_PATCH_BIT 0xb0
- #define MSDC_PATCH_BIT1 0xb4
- #define MSDC_PATCH_BIT2 0xb8
-+#define MSDC_PAD_CTRL0 0xe0
-+#define MSDC_PAD_CTRL1 0xe4
-+#define MSDC_PAD_CTRL2 0xe8
- #define MSDC_PAD_TUNE 0xec
- #define MSDC_PAD_TUNE0 0xf0
-+#define MSDC_PAD_TUNE1 0xf4
- #define PAD_DS_TUNE 0x188
- #define PAD_CMD_TUNE 0x18c
- #define EMMC51_CFG0 0x204
-@@ -408,6 +412,7 @@ struct mtk_mmc_compatible {
- bool enhance_rx;
- bool support_64g;
- bool use_internal_cd;
-+ bool legacy_mt762x; /* for mt7620, mt7621 and mt76x8 */
- };
-
- struct msdc_tune_para {
-@@ -547,6 +552,7 @@ static const struct mtk_mmc_compatible m
- .stop_clk_fix = false,
- .enhance_rx = false,
- .use_internal_cd = true,
-+ .legacy_mt762x = true,
- };
-
- static const struct mtk_mmc_compatible mt7622_compat = {
-@@ -1763,9 +1769,11 @@ static void msdc_init_hw(struct msdc_hos
- }
- writel(0, host->base + MSDC_IOCON);
- sdr_set_field(host->base + MSDC_IOCON, MSDC_IOCON_DDLSEL, 0);
-- writel(0x403c0046, host->base + MSDC_PATCH_BIT);
-- sdr_set_field(host->base + MSDC_PATCH_BIT, MSDC_CKGEN_MSDC_DLY_SEL, 1);
-- writel(0xffff4089, host->base + MSDC_PATCH_BIT1);
-+ if(!host->dev_comp->legacy_mt762x) {
-+ writel(0x403c0046, host->base + MSDC_PATCH_BIT);
-+ sdr_set_field(host->base + MSDC_PATCH_BIT, MSDC_CKGEN_MSDC_DLY_SEL, 1);
-+ writel(0xffff4089, host->base + MSDC_PATCH_BIT1);
-+ }
- sdr_set_bits(host->base + EMMC50_CFG0, EMMC50_CFG_CFCSTS_SEL);
-
- if (host->dev_comp->stop_clk_fix) {
-@@ -1839,6 +1847,18 @@ static void msdc_init_hw(struct msdc_hos
- MSDC_PAD_TUNE_RXDLYSEL);
- }
-
-+ if (host->dev_comp->legacy_mt762x) {
-+ /* Set pins drive strength */
-+ writel(0x000d0044, host->base + MSDC_PAD_CTRL0);
-+ writel(0x000e0044, host->base + MSDC_PAD_CTRL1);
-+ writel(0x000e0044, host->base + MSDC_PAD_CTRL2);
-+
-+ /* Set pad delay */
-+ writel(0x84101010, host->base + MSDC_PAD_TUNE);
-+ writel(0x10101010, host->base + MSDC_PAD_TUNE0);
-+ writel(0x10101010, host->base + MSDC_PAD_TUNE1);
-+ }
-+
- if (mmc->caps2 & MMC_CAP2_NO_SDIO) {
- sdr_clr_bits(host->base + SDC_CFG, SDC_CFG_SDIO);
- sdr_clr_bits(host->base + MSDC_INTEN, MSDC_INTEN_SDIOIRQ);
diff --git a/target/linux/ramips/patches-6.6/831-01-mmc-mtk-sd-add-tuning-parameters-for-legacy-MIPS-MT7.patch b/target/linux/ramips/patches-6.6/831-01-mmc-mtk-sd-add-tuning-parameters-for-legacy-MIPS-MT7.patch
new file mode 100644
index 0000000000..627bb7e4d0
--- /dev/null
+++ b/target/linux/ramips/patches-6.6/831-01-mmc-mtk-sd-add-tuning-parameters-for-legacy-MIPS-MT7.patch
@@ -0,0 +1,81 @@
+From: Shiji Yang <yangshiji66 at outlook.com>
+Date: Sat, 24 May 2025 15:53:26 +0800
+Subject: [PATCH 1/3] mmc: mtk-sd: add tuning parameters for legacy MIPS MT762x
+ SoCs
+
+The MIPS MT762x SoCs require some specific tuning parameters at
+different clock frequencies. These legacy SoCs only support max
+48~50 MHz High-Speed SD mode. Therefore, the standard tuning step
+is not available. We have to hard code these tuning parameters
+to make them work properly.
+
+Signed-off-by: Shiji Yang <yangshiji66 at outlook.com>
+---
+ drivers/mmc/host/mtk-sd.c | 26 +++++++++++++++++++++++++-
+ 1 file changed, 25 insertions(+), 1 deletion(-)
+
+--- a/drivers/mmc/host/mtk-sd.c
++++ b/drivers/mmc/host/mtk-sd.c
+@@ -76,8 +76,13 @@
+ #define MSDC_PATCH_BIT 0xb0
+ #define MSDC_PATCH_BIT1 0xb4
+ #define MSDC_PATCH_BIT2 0xb8
++#define MSDC_PAD_CTRL0 0xe0
++#define MSDC_PAD_CTRL1 0xe4
++#define MSDC_PAD_CTRL2 0xe8
+ #define MSDC_PAD_TUNE 0xec
+ #define MSDC_PAD_TUNE0 0xf0
++#define MSDC_DAT_RDDLY0 0xf0
++#define MSDC_DAT_RDDLY1 0xf4
+ #define PAD_DS_TUNE 0x188
+ #define PAD_CMD_TUNE 0x18c
+ #define EMMC51_CFG0 0x204
+@@ -403,6 +408,7 @@ struct mtk_mmc_compatible {
+ bool enhance_rx;
+ bool support_64g;
+ bool use_internal_cd;
++ bool mips_mt762x;
+ };
+
+ struct msdc_tune_para {
+@@ -541,6 +547,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = false,
+ .enhance_rx = false,
+ .use_internal_cd = true,
++ .mips_mt762x = true,
+ };
+
+ static const struct mtk_mmc_compatible mt7622_compat = {
+@@ -964,7 +971,12 @@ static void msdc_set_mclk(struct msdc_ho
+ * mmc_select_hs400() will drop to 50Mhz and High speed mode,
+ * tune result of hs200/200Mhz is not suitable for 50Mhz
+ */
+- if (mmc->actual_clock <= 52000000) {
++ if (host->dev_comp->mips_mt762x &&
++ mmc->actual_clock > 25000000) {
++ sdr_set_bits(host->base + MSDC_IOCON, MSDC_IOCON_RSPL);
++ sdr_set_bits(host->base + MSDC_IOCON, MSDC_IOCON_DSPL);
++ sdr_set_bits(host->base + MSDC_IOCON, MSDC_IOCON_W_DSPL);
++ } else if (mmc->actual_clock <= 52000000) {
+ writel(host->def_tune_para.iocon, host->base + MSDC_IOCON);
+ if (host->top_base) {
+ writel(host->def_tune_para.emmc_top_control,
+@@ -1822,6 +1834,18 @@ static void msdc_init_hw(struct msdc_hos
+ MSDC_PAD_TUNE_RXDLYSEL);
+ }
+
++ if (host->dev_comp->mips_mt762x) {
++ /* Set pins drive strength */
++ writel(0x000d0044, host->base + MSDC_PAD_CTRL0);
++ writel(0x000e0044, host->base + MSDC_PAD_CTRL1);
++ writel(0x000e0044, host->base + MSDC_PAD_CTRL2);
++
++ /* Set tuning parameters */
++ writel(0x84101010, host->base + tune_reg);
++ writel(0x10101010, host->base + MSDC_DAT_RDDLY0);
++ writel(0x10101010, host->base + MSDC_DAT_RDDLY1);
++ }
++
+ if (mmc->caps2 & MMC_CAP2_NO_SDIO) {
+ sdr_clr_bits(host->base + SDC_CFG, SDC_CFG_SDIO);
+ sdr_clr_bits(host->base + MSDC_INTEN, MSDC_INTEN_SDIOIRQ);
diff --git a/target/linux/ramips/patches-6.6/831-02-mmc-mtk-sd-disable-auto-CMD23-support-for-mt7620.patch b/target/linux/ramips/patches-6.6/831-02-mmc-mtk-sd-disable-auto-CMD23-support-for-mt7620.patch
new file mode 100644
index 0000000000..59b70ef537
--- /dev/null
+++ b/target/linux/ramips/patches-6.6/831-02-mmc-mtk-sd-disable-auto-CMD23-support-for-mt7620.patch
@@ -0,0 +1,137 @@
+From: Shiji Yang <yangshiji66 at outlook.com>
+Date: Fri, 13 Jun 2025 20:12:55 +0800
+Subject: [PATCH 2/3] mmc: mtk-sd: disable auto CMD23 support for mt7620
+
+MT7628 ProgrammingGuide indicates that the host controller version
+3.0 and later support auto CMD23 function. However, it doesn't
+define SD command register BIT[29](Auto CMD23 enable bit). I guess
+the legacy MIPS MT762x series SoCs don't support this feature at
+all. The experiment on JDCloud RE-SP-01B(MT7621 + 128 GiB EMMC)
+shows that disabling auto CMD23 can fix the following IO errors:
+
+[ 143.344604] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002
+[ 143.353661] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002
+[ 143.362662] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002
+[ 143.371684] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002
+[ 143.380684] I/O error, dev mmcblk0boot0, sector 0 op 0x0:(READ) flags 0x80700 phys_seg 4 prio class 0
+[ 143.390414] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002
+[ 143.399468] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002
+[ 143.408516] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002
+[ 143.417556] mtk-msdc 1e130000.mmc: msdc_track_cmd_data: cmd=6 arg=03B30101; host->error=0x00000002
+[ 143.426590] I/O error, dev mmcblk0boot0, sector 0 op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0
+[ 143.435585] Buffer I/O error on dev mmcblk0boot0, logical block 0, async page read
+
+Signed-off-by: Shiji Yang <yangshiji66 at outlook.com>
+---
+ drivers/mmc/host/mtk-sd.c | 16 +++++++++++++++-
+ 1 file changed, 15 insertions(+), 1 deletion(-)
+
+--- a/drivers/mmc/host/mtk-sd.c
++++ b/drivers/mmc/host/mtk-sd.c
+@@ -407,6 +407,7 @@ struct mtk_mmc_compatible {
+ bool stop_clk_fix;
+ bool enhance_rx;
+ bool support_64g;
++ bool support_cmd23;
+ bool use_internal_cd;
+ bool mips_mt762x;
+ };
+@@ -495,6 +496,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = false,
+ .enhance_rx = false,
+ .support_64g = false,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt2712_compat = {
+@@ -508,6 +510,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = true,
+ .enhance_rx = true,
+ .support_64g = true,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt6779_compat = {
+@@ -521,6 +524,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = true,
+ .enhance_rx = true,
+ .support_64g = true,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt6795_compat = {
+@@ -534,6 +538,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = false,
+ .enhance_rx = false,
+ .support_64g = false,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt7620_compat = {
+@@ -546,6 +551,7 @@ static const struct mtk_mmc_compatible m
+ .busy_check = false,
+ .stop_clk_fix = false,
+ .enhance_rx = false,
++ .support_cmd23 = false,
+ .use_internal_cd = true,
+ .mips_mt762x = true,
+ };
+@@ -561,6 +567,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = true,
+ .enhance_rx = true,
+ .support_64g = false,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt7986_compat = {
+@@ -574,6 +581,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = true,
+ .enhance_rx = true,
+ .support_64g = true,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt8135_compat = {
+@@ -587,6 +595,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = false,
+ .enhance_rx = false,
+ .support_64g = false,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt8173_compat = {
+@@ -600,6 +609,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = false,
+ .enhance_rx = false,
+ .support_64g = false,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt8183_compat = {
+@@ -613,6 +623,7 @@ static const struct mtk_mmc_compatible m
+ .stop_clk_fix = true,
+ .enhance_rx = true,
+ .support_64g = true,
++ .support_cmd23 = true,
+ };
+
+ static const struct mtk_mmc_compatible mt8516_compat = {
+@@ -624,6 +635,7 @@ static const struct mtk_mmc_compatible m
+ .data_tune = true,
+ .busy_check = true,
+ .stop_clk_fix = true,
++ .support_cmd23 = true,
+ };
+
+ static const struct of_device_id msdc_of_ids[] = {
+@@ -2834,7 +2846,9 @@ static int msdc_drv_probe(struct platfor
+ if (mmc->caps & MMC_CAP_SDIO_IRQ)
+ mmc->caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD;
+
+- mmc->caps |= MMC_CAP_CMD23;
++ if (host->dev_comp->support_cmd23)
++ mmc->caps |= MMC_CAP_CMD23;
++
+ if (host->cqhci)
+ mmc->caps2 |= MMC_CAP2_CQE | MMC_CAP2_CQE_DCMD;
+ /* MMC core transfer sizes tunable parameters */
diff --git a/target/linux/ramips/patches-6.6/831-03-mmc-mtk-sd-use-default-PATCH_BIT1-2-values-for-mt762.patch b/target/linux/ramips/patches-6.6/831-03-mmc-mtk-sd-use-default-PATCH_BIT1-2-values-for-mt762.patch
new file mode 100644
index 0000000000..321fd69c93
--- /dev/null
+++ b/target/linux/ramips/patches-6.6/831-03-mmc-mtk-sd-use-default-PATCH_BIT1-2-values-for-mt762.patch
@@ -0,0 +1,30 @@
+From: Shiji Yang <yangshiji66 at outlook.com>
+Date: Sat, 24 May 2025 15:53:26 +0800
+Subject: [PATCH 3/3] mmc: mtk-sd: use default PATCH_BIT1/2 values for mt7620
+
+The definitions of these two registers seem to be slightly different
+from other variants. Use their default values to follow the vendor
+SDK driver behaviors.
+
+Signed-off-by: Shiji Yang <yangshiji66 at outlook.com>
+---
+ drivers/mmc/host/mtk-sd.c | 8 +++++---
+ 1 file changed, 5 insertions(+), 3 deletions(-)
+
+--- a/drivers/mmc/host/mtk-sd.c
++++ b/drivers/mmc/host/mtk-sd.c
+@@ -1780,9 +1780,11 @@ static void msdc_init_hw(struct msdc_hos
+ }
+ writel(0, host->base + MSDC_IOCON);
+ sdr_set_field(host->base + MSDC_IOCON, MSDC_IOCON_DDLSEL, 0);
+- writel(0x403c0046, host->base + MSDC_PATCH_BIT);
+- sdr_set_field(host->base + MSDC_PATCH_BIT, MSDC_CKGEN_MSDC_DLY_SEL, 1);
+- writel(0xffff4089, host->base + MSDC_PATCH_BIT1);
++ if (!host->dev_comp->mips_mt762x) {
++ writel(0x403c0046, host->base + MSDC_PATCH_BIT);
++ sdr_set_field(host->base + MSDC_PATCH_BIT, MSDC_CKGEN_MSDC_DLY_SEL, 1);
++ writel(0xffff4089, host->base + MSDC_PATCH_BIT1);
++ }
+ sdr_set_bits(host->base + EMMC50_CFG0, EMMC50_CFG_CFCSTS_SEL);
+
+ if (host->dev_comp->stop_clk_fix) {
diff --git a/target/linux/ramips/patches-6.6/831-mmc-mtk-sd-initialize-pad-delay-and-drive-strength.patch b/target/linux/ramips/patches-6.6/831-mmc-mtk-sd-initialize-pad-delay-and-drive-strength.patch
deleted file mode 100644
index 3b5b5eb93d..0000000000
--- a/target/linux/ramips/patches-6.6/831-mmc-mtk-sd-initialize-pad-delay-and-drive-strength.patch
+++ /dev/null
@@ -1,74 +0,0 @@
-From: Shiji Yang <yangshiji66 at outlook.com>
-Date: Wed, 10 Jul 2024 12:18:52 +0800
-Subject: [PATCH] mmc: mtk-sd: initialize the pad and tune registers
-
-Signed-off-by: Shiji Yang <yangshiji66 at outlook.com>
----
- drivers/mmc/host/mtk-sd.c | 26 +++++++++++++++++++++++---
- 1 file changed, 23 insertions(+), 3 deletions(-)
-
---- a/drivers/mmc/host/mtk-sd.c
-+++ b/drivers/mmc/host/mtk-sd.c
-@@ -76,8 +76,12 @@
- #define MSDC_PATCH_BIT 0xb0
- #define MSDC_PATCH_BIT1 0xb4
- #define MSDC_PATCH_BIT2 0xb8
-+#define MSDC_PAD_CTRL0 0xe0
-+#define MSDC_PAD_CTRL1 0xe4
-+#define MSDC_PAD_CTRL2 0xe8
- #define MSDC_PAD_TUNE 0xec
- #define MSDC_PAD_TUNE0 0xf0
-+#define MSDC_PAD_TUNE1 0xf4
- #define PAD_DS_TUNE 0x188
- #define PAD_CMD_TUNE 0x18c
- #define EMMC51_CFG0 0x204
-@@ -403,6 +407,7 @@ struct mtk_mmc_compatible {
- bool enhance_rx;
- bool support_64g;
- bool use_internal_cd;
-+ bool legacy_mt762x; /* for mt7620, mt7621 and mt76x8 */
- };
-
- struct msdc_tune_para {
-@@ -541,6 +546,7 @@ static const struct mtk_mmc_compatible m
- .stop_clk_fix = false,
- .enhance_rx = false,
- .use_internal_cd = true,
-+ .legacy_mt762x = true,
- };
-
- static const struct mtk_mmc_compatible mt7622_compat = {
-@@ -1756,9 +1762,11 @@ static void msdc_init_hw(struct msdc_hos
- }
- writel(0, host->base + MSDC_IOCON);
- sdr_set_field(host->base + MSDC_IOCON, MSDC_IOCON_DDLSEL, 0);
-- writel(0x403c0046, host->base + MSDC_PATCH_BIT);
-- sdr_set_field(host->base + MSDC_PATCH_BIT, MSDC_CKGEN_MSDC_DLY_SEL, 1);
-- writel(0xffff4089, host->base + MSDC_PATCH_BIT1);
-+ if(!host->dev_comp->legacy_mt762x) {
-+ writel(0x403c0046, host->base + MSDC_PATCH_BIT);
-+ sdr_set_field(host->base + MSDC_PATCH_BIT, MSDC_CKGEN_MSDC_DLY_SEL, 1);
-+ writel(0xffff4089, host->base + MSDC_PATCH_BIT1);
-+ }
- sdr_set_bits(host->base + EMMC50_CFG0, EMMC50_CFG_CFCSTS_SEL);
-
- if (host->dev_comp->stop_clk_fix) {
-@@ -1822,6 +1830,18 @@ static void msdc_init_hw(struct msdc_hos
- MSDC_PAD_TUNE_RXDLYSEL);
- }
-
-+ if (host->dev_comp->legacy_mt762x) {
-+ /* Set pins drive strength */
-+ writel(0x000d0044, host->base + MSDC_PAD_CTRL0);
-+ writel(0x000e0044, host->base + MSDC_PAD_CTRL1);
-+ writel(0x000e0044, host->base + MSDC_PAD_CTRL2);
-+
-+ /* Set pad delay */
-+ writel(0x84101010, host->base + MSDC_PAD_TUNE);
-+ writel(0x10101010, host->base + MSDC_PAD_TUNE0);
-+ writel(0x10101010, host->base + MSDC_PAD_TUNE1);
-+ }
-+
- if (mmc->caps2 & MMC_CAP2_NO_SDIO) {
- sdr_clr_bits(host->base + SDC_CFG, SDC_CFG_SDIO);
- sdr_clr_bits(host->base + MSDC_INTEN, MSDC_INTEN_SDIOIRQ);
More information about the lede-commits
mailing list