[openwrt/openwrt] tools/coreutils: disable uninstall target
LEDE Commits
lede-commits at lists.infradead.org
Sat Jul 26 05:38:39 PDT 2025
robimarko pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/5c832d783381831289c4f65d2a821a0eecfc435f
commit 5c832d783381831289c4f65d2a821a0eecfc435f
Author: Michael Pratt <mcpratt at pm.me>
AuthorDate: Mon Sep 30 15:59:06 2024 -0400
tools/coreutils: disable uninstall target
GNU coreutils is a unique case where we require
some of the utilities on the host machine
before anything is built.
The prerequisite is handled by symlinks to the host binaries
in the staging directory that are installed
by the build system and that are expected to remain
as long as the corresponding stampfile exists.
Because the binaries built by coreutils
will replace the symlinks, the uninstall target
will actually delete the symlinks
long before the build finishes whenever it is ran.
This can cause the utilities to be temporarily missing
from the controlled part of the shell's PATH,
so disable the removal of the coreutils utilities.
The appropriate way to clear all of the programs and links
would be `make dirclean`.
Tested-by: Georgi Valkov <gvalkov at gmail.com> # macOS
Signed-off-by: Michael Pratt <mcpratt at pm.me>
Link: https://github.com/openwrt/openwrt/pull/16522
Signed-off-by: Robert Marko <robimarko at gmail.com>
---
tools/coreutils/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/coreutils/Makefile b/tools/coreutils/Makefile
index 42f03317d9..84aba9e64a 100644
--- a/tools/coreutils/Makefile
+++ b/tools/coreutils/Makefile
@@ -73,7 +73,7 @@ define Host/Install
endef
define Host/Uninstall
- -$(call Host/Compile/Default,uninstall)
+ #$(call Host/Compile/Default,uninstall) # Removes necessary symlinks
-$(call Host/Compile/Default,maintainer-clean) # Clean bootstrap files from the release
endef
More information about the lede-commits
mailing list