[openwrt/openwrt] base-files: always generate default DUID

LEDE Commits lede-commits at lists.infradead.org
Wed Dec 10 22:41:40 PST 2025


ynezz pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/52fa3728e5304ecdfca77332bdfe870696b95d35

commit 52fa3728e5304ecdfca77332bdfe870696b95d35
Author: David Härdeman <david at hardeman.nu>
AuthorDate: Tue Dec 9 23:49:48 2025 +0100

    base-files: always generate default DUID
    
    The previous logic was copied from 12_network-generate-ula, but fails to
    account for upgrades where the "auto" value isn't set (it is set by
    base-files/files/bin/config_generate). Fix this to always set the
    default duid if it isn't set.
    
    Also, rename the file to better reflect what it does.
    
    Closes: #21029
    Fixes: a660a076db5a ("base-files: generate a global DHCP DUID")
    Link: https://github.com/openwrt/openwrt/pull/21118
    Signed-off-by: David Härdeman <david at hardeman.nu>
    Signed-off-by: Petr Štetiar <ynezz at true.cz> [fixes,closes tag]
---
 .../{14_network-generate-clientid => 14_network-generate-duid}          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/base-files/files/etc/uci-defaults/14_network-generate-clientid b/package/base-files/files/etc/uci-defaults/14_network-generate-duid
similarity index 69%
rename from package/base-files/files/etc/uci-defaults/14_network-generate-clientid
rename to package/base-files/files/etc/uci-defaults/14_network-generate-duid
index 11806dd19c..c793dba695 100644
--- a/package/base-files/files/etc/uci-defaults/14_network-generate-clientid
+++ b/package/base-files/files/etc/uci-defaults/14_network-generate-duid
@@ -1,4 +1,4 @@
-[ "$(uci -q get network.globals.dhcp_default_duid)" != "auto" ] && exit 0
+[ "$(uci -q get network.globals.dhcp_default_duid || echo "auto")" != "auto" ] && exit 0
 
 uci -q batch <<-EOF >/dev/null
 	# DUID-UUID - RFC6355




More information about the lede-commits mailing list