[openwrt/openwrt] ath10k-ct: silence some harmless noisy logs
LEDE Commits
lede-commits at lists.infradead.org
Thu Apr 10 11:55:28 PDT 2025
hauke pushed a commit to openwrt/openwrt.git, branch openwrt-24.10:
https://git.openwrt.org/30c1c6d7c31e031aea1d4dc082c8d137f5653a0a
commit 30c1c6d7c31e031aea1d4dc082c8d137f5653a0a
Author: Shiji Yang <yangshiji66 at outlook.com>
AuthorDate: Sat Mar 29 00:00:50 2025 +0800
ath10k-ct: silence some harmless noisy logs
Users feel anxious about some ath10k driver logs. After further
investigation, in fact these logs are harmless. Only developers
need to care about them in order to optimize some parameters.
Let's just silence them to reduce these similar user reports.
Closes: https://github.com/openwrt/openwrt/issues/13148
Closes: https://github.com/openwrt/openwrt/issues/14422
Closes: https://github.com/openwrt/openwrt/issues/15959
Closes: https://github.com/openwrt/openwrt/issues/15997
Closes: https://github.com/openwrt/openwrt/issues/16896
Closes: https://github.com/openwrt/openwrt/issues/18046
Signed-off-by: Shiji Yang <yangshiji66 at outlook.com>
Link: https://github.com/openwrt/openwrt/pull/18368
Signed-off-by: Robert Marko <robimarko at gmail.com>
(cherry picked from commit 88234a03bc645d327016cc807c35972fcb6834eb)
[Apply to ath10k-ct 6.10]
Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de>
---
...ilence-warning-caused-by-unsupported-retr.patch | 34 ++++++++++++++++++++++
...ilence-noisy-log-caused-by-flushing-queue.patch | 31 ++++++++++++++++++++
...ath10k-always-use-mac80211-loss-detection.patch | 2 +-
3 files changed, 66 insertions(+), 1 deletion(-)
diff --git a/package/kernel/ath10k-ct/patches/205-ath10k-ct-silence-warning-caused-by-unsupported-retr.patch b/package/kernel/ath10k-ct/patches/205-ath10k-ct-silence-warning-caused-by-unsupported-retr.patch
new file mode 100644
index 0000000000..9d6b0954ff
--- /dev/null
+++ b/package/kernel/ath10k-ct/patches/205-ath10k-ct-silence-warning-caused-by-unsupported-retr.patch
@@ -0,0 +1,34 @@
+From: Shiji Yang <yangshiji66 at outlook.com>
+Date: Fri, 28 Mar 2025 20:26:04 +0800
+Subject: [PATCH] ath10k-ct: silence warning caused by unsupported retry_limit
+ value
+
+Some retry_limit values are not supported by ath10k wave2 chips.
+We can just skip config it for these chips. And it's safe to
+return 0 in this case because the hardware is still working.
+
+Suggested-by: Ben Greear <greearb at candelatech.com>
+Signed-off-by: Shiji Yang <yangshiji66 at outlook.com>
+---
+ ath10k-6.14/mac.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+--- a/ath10k-6.10/mac.c
++++ b/ath10k-6.10/mac.c
+@@ -5395,7 +5395,7 @@ static int ath10k_config_retry_limit(str
+ */
+ ath10k_warn(ar, "Firmware lacks feature flag indicating a retry limit of > 2 is OK, requested limit: %d\n",
+ limit);
+- return -EINVAL;
++ goto skip_retry_limit;
+ }
+
+ list_for_each_entry(arvif, &ar->arvifs, list) {
+@@ -5406,6 +5406,7 @@ static int ath10k_config_retry_limit(str
+ }
+ }
+
++skip_retry_limit:
+ return ret;
+ }
+
diff --git a/package/kernel/ath10k-ct/patches/206-ath10k-ct-silence-noisy-log-caused-by-flushing-queue.patch b/package/kernel/ath10k-ct/patches/206-ath10k-ct-silence-noisy-log-caused-by-flushing-queue.patch
new file mode 100644
index 0000000000..8b8042e5d7
--- /dev/null
+++ b/package/kernel/ath10k-ct/patches/206-ath10k-ct-silence-noisy-log-caused-by-flushing-queue.patch
@@ -0,0 +1,31 @@
+From: Shiji Yang <yangshiji66 at outlook.com>
+Date: Fri, 28 Mar 2025 21:02:27 +0800
+Subject: [PATCH] ath10k-ct: silence noisy log caused by flushing queue
+
+.flush() is a regular mac80211 operation aims to clear all pending
+frames from the hardware queue. Only developers need to care about it.
+
+Signed-off-by: Shiji Yang <yangshiji66 at outlook.com>
+---
+ ath10k-6.14/mac.c | 8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+--- a/ath10k-6.10/mac.c
++++ b/ath10k-6.10/mac.c
+@@ -9061,12 +9061,12 @@ static void ath10k_flush(struct ieee8021
+ if (vif) {
+ arvif = (void *)vif->drv_priv;
+ vid = arvif->vdev_id;
+- ath10k_info(ar, "mac flush vdev %d drop %d queues 0x%x ar->paused: 0x%lx arvif->paused: 0x%lx\n",
+- arvif->vdev_id, drop, queues, ar->tx_paused, arvif->tx_paused);
++ ath10k_dbg(ar, ATH10K_DBG_MAC, "mac flush vdev %d drop %d queues 0x%x ar->paused: 0x%lx arvif->paused: 0x%lx\n",
++ arvif->vdev_id, drop, queues, ar->tx_paused, arvif->tx_paused);
+ }
+ else {
+- ath10k_info(ar, "mac flush null vif, drop %d queues 0x%x\n",
+- drop, queues);
++ ath10k_dbg(ar, ATH10K_DBG_MAC, "mac flush null vif, drop %d queues 0x%x\n",
++ drop, queues);
+ }
+
+
diff --git a/package/kernel/ath10k-ct/patches/988-ath10k-always-use-mac80211-loss-detection.patch b/package/kernel/ath10k-ct/patches/988-ath10k-always-use-mac80211-loss-detection.patch
index 35026cc0f9..1f9f38c2b0 100644
--- a/package/kernel/ath10k-ct/patches/988-ath10k-always-use-mac80211-loss-detection.patch
+++ b/package/kernel/ath10k-ct/patches/988-ath10k-always-use-mac80211-loss-detection.patch
@@ -18,7 +18,7 @@ Signed-off-by: David Bauer <mail at david-bauer.net>
--- a/ath10k-6.10/mac.c
+++ b/ath10k-6.10/mac.c
-@@ -11316,7 +11316,6 @@ int ath10k_mac_register(struct ath10k *a
+@@ -11317,7 +11317,6 @@ int ath10k_mac_register(struct ath10k *a
ieee80211_hw_set(ar->hw, CHANCTX_STA_CSA);
ieee80211_hw_set(ar->hw, QUEUE_CONTROL);
ieee80211_hw_set(ar->hw, SUPPORTS_TX_FRAG);
More information about the lede-commits
mailing list