[openwrt/openwrt] lldpd: remove unneeded quotes and variable quoting

LEDE Commits lede-commits at lists.infradead.org
Tue Sep 17 03:36:37 PDT 2024


robimarko pushed a commit to openwrt/openwrt.git, branch openwrt-23.05:
https://git.openwrt.org/64b38f3bd564eda2a473fbb06cf0fa56f54ec10e

commit 64b38f3bd564eda2a473fbb06cf0fa56f54ec10e
Author: Paul Donald <newtwen at gmail.com>
AuthorDate: Thu Feb 8 21:42:11 2024 +0100

    lldpd: remove unneeded quotes and variable quoting
    
    from commit c98ee4dbb3db0f064d990941cdd82e872da76946
    
    agent-type takes 1 of 3 possible keywords which do not require quoting:
    
             configure lldp agent-type nearest-bridge | nearest-non-tpmr-bridge
             | nearest-customer-bridge
    
    Tested on 22.03.5
    
    Signed-off-by: Paul Donald <newtwen at gmail.com>
    (cherry picked from commit 24a4da527f7e70d9916439a78298de2f4e4af653)
    Link: https://github.com/openwrt/openwrt/pull/15299
    Signed-off-by: Robert Marko <robimarko at gmail.com>
---
 package/network/services/lldpd/files/lldpd.init | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init
index 3fc47bb3e3..243a32c937 100644
--- a/package/network/services/lldpd/files/lldpd.init
+++ b/package/network/services/lldpd/files/lldpd.init
@@ -153,7 +153,7 @@ write_lldpd_conf()
 			echo "configure med fast-start enable" >> "$LLDPD_CONF"
 		fi
 	fi
-	[ -n "$lldp_agenttype" ] && echo "configure lldp agent-type" "\"$lldp_agenttype\"" >> "$LLDPD_CONF"
+	[ -n "$lldp_agenttype" ] && echo "configure lldp agent-type $lldp_agenttype" >> "$LLDPD_CONF"
 	[ -n "$lldp_portidsubtype" ] && echo "configure lldp portidsubtype" "\"$lldp_portidsubtype\"" >> "$LLDPD_CONF"
 	[ -n "$lldp_platform" ] && echo "configure system platform" "\"$lldp_platform\"" >> "$LLDPD_CONF"
 	[ $lldp_tx_interval -gt 0 ] && echo "configure lldp tx-interval" "$lldp_tx_interval" >> "$LLDPD_CONF"




More information about the lede-commits mailing list