[openwrt/openwrt] build: ensure silent Make behavior for json scripts

LEDE Commits lede-commits at lists.infradead.org
Fri Nov 29 12:45:15 PST 2024


ansuel pushed a commit to openwrt/openwrt.git, branch openwrt-23.05:
https://git.openwrt.org/6d5c434b1419f2c5c84549d5ef48b73f52f9e9d6

commit 6d5c434b1419f2c5c84549d5ef48b73f52f9e9d6
Author: Michael Pratt <mcpratt at pm.me>
AuthorDate: Fri Nov 24 05:10:12 2023 -0500

    build: ensure silent Make behavior for json scripts
    
    Run the invocation of Make with verbosity in order to
    prevent the printing of Makefile level and subtarget status.
    e.g.  make[3] -C target/linux val.DEFAULT_PACKAGES val.ARCH_PACKAGES
    
    Remove piping of stderr, which is only useful when using
    the "communicate" method over the "run" method,
    and this script would not be written to handle a captured error anyway.
    
    For error testing, stdout and stderr can be set to a file object
    with the open() function like this:
    
    out = open('json_out', 'w')
    err = open('json_err', 'w')
    
    ...
    ...
    stdout=out,
    stderr=err,
    
    Signed-off-by: Michael Pratt <mcpratt at pm.me>
    (cherry picked from commit fd3376c5eeccc1f1753483ed31ffff03808ce31d)
---
 scripts/json_overview_image_info.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/json_overview_image_info.py b/scripts/json_overview_image_info.py
index 89b7d4fe20..0d2cf7f1ef 100755
--- a/scripts/json_overview_image_info.py
+++ b/scripts/json_overview_image_info.py
@@ -55,9 +55,9 @@ if output:
             "target/linux/",
             "val.DEFAULT_PACKAGES",
             "val.ARCH_PACKAGES",
+            "V=s",
         ],
         stdout=PIPE,
-        stderr=PIPE,
         check=True,
         env=environ.copy().update({"TOPDIR": Path().cwd()}),
         universal_newlines=True,




More information about the lede-commits mailing list