[openwrt/openwrt] realtek: rtl83xx: use devm for mutex_init

LEDE Commits lede-commits at lists.infradead.org
Tue Nov 12 02:19:55 PST 2024


robimarko pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/1125ed408c7f0d130b5606ab39e4dd98a41d5f0a

commit 1125ed408c7f0d130b5606ab39e4dd98a41d5f0a
Author: Rosen Penev <rosenp at gmail.com>
AuthorDate: Sun Nov 10 15:54:14 2024 -0800

    realtek: rtl83xx: use devm for mutex_init
    
    mutex_destroy is missing in remove.
    
    Signed-off-by: Rosen Penev <rosenp at gmail.com>
    Link: https://github.com/openwrt/openwrt/pull/16926
    Signed-off-by: Robert Marko <robimarko at gmail.com>
---
 target/linux/realtek/files-6.6/drivers/net/dsa/rtl83xx/common.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/target/linux/realtek/files-6.6/drivers/net/dsa/rtl83xx/common.c b/target/linux/realtek/files-6.6/drivers/net/dsa/rtl83xx/common.c
index 5468fc0653..fe0980a1be 100644
--- a/target/linux/realtek/files-6.6/drivers/net/dsa/rtl83xx/common.c
+++ b/target/linux/realtek/files-6.6/drivers/net/dsa/rtl83xx/common.c
@@ -1492,7 +1492,9 @@ static int __init rtl83xx_sw_probe(struct platform_device *pdev)
 	priv->ds->needs_standalone_vlan_filtering = true;
 	priv->dev = dev;
 
-	mutex_init(&priv->reg_mutex);
+	err = devm_mutex_init(dev, &priv->reg_mutex);
+	if (err)
+		return err;
 
 	priv->family_id = soc_info.family;
 	priv->id = soc_info.id;




More information about the lede-commits mailing list