[openwrt/openwrt] tools: util-linux: disable NLS again

LEDE Commits lede-commits at lists.infradead.org
Tue Jul 9 01:55:13 PDT 2024


robimarko pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/f8ccf8a7a8a4c52eff1c3c1738fb75b4896be1bc

commit f8ccf8a7a8a4c52eff1c3c1738fb75b4896be1bc
Author: Robert Marko <robimarko at gmail.com>
AuthorDate: Mon Jul 8 20:47:01 2024 +0200

    tools: util-linux: disable NLS again
    
    It seems that util-linux enables NLS support by default, this worked for
    almost all platforms except for macOS on x86 where it seems that libintl is
    preinstalled and thus it will link against gettext with libintl for NLS
    support.
    
    This would the later cause e2fsprogs and mtd-utils to fail:
    Undefined symbols for architecture x86_64:
      "_libintl_gettext", referenced from:
          _random_tell_source in libuuid.a[13](libuuid_la-randutils.o)
    ld: symbol(s) not found for architecture x86_64
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    
    Issue appeared after I converted the tool to use --disable-all-programs and
    accidentally dropped the --disable-nls from the args.
    
    Fixes: 54115ec22d15 ("tools: util-linux: use --disable-all-programs")
    Link: https://github.com/openwrt/openwrt/pull/15909
    Signed-off-by: Robert Marko <robimarko at gmail.com>
---
 tools/util-linux/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/util-linux/Makefile b/tools/util-linux/Makefile
index b4cc45efc8..0394907a96 100644
--- a/tools/util-linux/Makefile
+++ b/tools/util-linux/Makefile
@@ -23,6 +23,7 @@ include $(INCLUDE_DIR)/host-build.mk
 HOST_CONFIGURE_ARGS += \
 	--with-pic \
 	--disable-shared \
+	--disable-nls \
 	--disable-all-programs \
 	--enable-hexdump \
 	--enable-libuuid \




More information about the lede-commits mailing list