[openwrt/openwrt] qualcommax: remove usage of malibu_first_phy_addr

LEDE Commits lede-commits at lists.infradead.org
Thu Feb 15 09:26:02 PST 2024


robimarko pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/deda92c16c9f716d9585113c98546e421419dddb

commit deda92c16c9f716d9585113c98546e421419dddb
Author: Robert Marko <robimarko at gmail.com>
AuthorDate: Tue Feb 13 21:48:52 2024 +0100

    qualcommax: remove usage of malibu_first_phy_addr
    
    Now that Malibu (QCA807x) PHY is using the upstream driver, we dont need
    support to define address of the first PHY in package, so remove the
    malibu_first_phy_addr DTS property.
    
    Signed-off-by: Robert Marko <robimarko at gmail.com>
---
 .../files/arch/arm64/boot/dts/qcom/ipq8072-301w.dts    |  1 -
 .../files/arch/arm64/boot/dts/qcom/ipq8074-ess.dtsi    | 18 ------------------
 2 files changed, 19 deletions(-)

diff --git a/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq8072-301w.dts b/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq8072-301w.dts
index 4dcacdf297..58eefc30ba 100644
--- a/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq8072-301w.dts
+++ b/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq8072-301w.dts
@@ -414,7 +414,6 @@
 
 	switch_lan_bmp = <(ESS_PORT1 | ESS_PORT2 | ESS_PORT3 | ESS_PORT4 | ESS_PORT6)>; /* lan port bitmap */
 	switch_wan_bmp = <ESS_PORT5>; /* wan port bitmap */
-	malibu_first_phy_addr = <16>; /* PHY addr of the first malibu PHY */
 	switch_mac_mode = <MAC_MODE_QSGMII>; /* mac mode for uniphy instance0*/
 	switch_mac_mode1 = <MAC_MODE_USXGMII>; /* mac mode for uniphy instance1*/
 	switch_mac_mode2 = <MAC_MODE_USXGMII>; /* mac mode for uniphy instance2*/
diff --git a/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq8074-ess.dtsi b/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq8074-ess.dtsi
index 6f98e01b9a..76838b86c5 100644
--- a/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq8074-ess.dtsi
+++ b/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq8074-ess.dtsi
@@ -23,24 +23,6 @@
 		switch_access_mode = "local bus";
 		switch_cpu_bmp = <ESS_PORT0>;  /* cpu port bitmap */
 		switch_inner_bmp = <ESS_PORT7>; /*inner port bitmap*/
-		/* This is a special binding that controls how the malibu PHY are
-		 * init. This value reflect the PHY addr of the first malibu PHY.
-		 * Malibu PHY are in a bundle of 5 PHY.
-		 * Some device might have some port not connected.
-		 * SSDK still needs the addrs of the first PHY (even if not connected)
-		 * to correctly setup the malibu PHY.
-		 *
-		 * This is needed as previously SSDK based this on the port bmp, but
-		 * this can be problematic now that we specify correct bmp.
-		 *
-		 * Most common configuration have the malibu PHY placed at 0.
-		 * But some device might have it placed at address 16.
-		 * To drive the correct value, check the port id of the malibu PHY
-		 * and try to understand what is the first one in devices where some
-		 * port are missing. port_phyinfo is normally the way to go to derive
-		 * this value in the few special cases.
-		 */
-		malibu_first_phy_addr = <0>;
 		clocks = <&gcc GCC_CMN_12GPLL_AHB_CLK>,
 			 <&gcc GCC_CMN_12GPLL_SYS_CLK>,
 			 <&gcc GCC_UNIPHY0_AHB_CLK>,




More information about the lede-commits mailing list