[openwrt/openwrt] tools: libtool: do not symlink files in bootstrap

LEDE Commits lede-commits at lists.infradead.org
Thu Aug 29 11:04:45 PDT 2024


neocturne pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/d6e54593198851235906c6ab77c20c6209ab19f5

commit d6e54593198851235906c6ab77c20c6209ab19f5
Author: Matthias Schiffer <mschiffer at universe-factory.net>
AuthorDate: Thu Aug 29 20:04:02 2024 +0200

    tools: libtool: do not symlink files in bootstrap
    
    Another instance of files in build_dir symlinking to staging_dir. While
    the symlinks do not currently cause any bugs in the libtool package,
    such symlinks were found to make the build more fragile, as writing to
    the symlink may accidentally modify the shared file in staging_dir. Pass
    --copy to bootstrap to disable the symlinking.
    
    Link: https://github.com/openwrt/openwrt/pull/15825
    Signed-off-by: Matthias Schiffer <mschiffer at universe-factory.net>
---
 tools/libtool/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/libtool/Makefile b/tools/libtool/Makefile
index dd9afc05bd..533360d199 100644
--- a/tools/libtool/Makefile
+++ b/tools/libtool/Makefile
@@ -28,6 +28,7 @@ define Host/Bootstrap
 		cd $(HOST_BUILD_DIR); \
 		$(AM_TOOL_PATHS) \
 		./bootstrap \
+			--copy \
 			--force \
 			--skip-git \
 			--skip-po \




More information about the lede-commits mailing list