[buildbot] phase2: fix relative paths for scripts and files

LEDE Commits lede-commits at lists.infradead.org
Fri Apr 12 23:33:05 PDT 2024


ynezz pushed a commit to buildbot.git, branch main:
https://git.openwrt.org/7d371c4ae28b414e2c4321a88453a97e99093b26

commit 7d371c4ae28b414e2c4321a88453a97e99093b26
Author: Petr Štetiar <ynezz at true.cz>
AuthorDate: Sun Dec 24 19:14:14 2023 +0000

    phase2: fix relative paths for scripts and files
    
    Currently `buildlist` step fails with following:
    
      ../../../sha2rsync.pl ../../arch-sha256sums bin/packages/aarch64_generic/sha256sums rsynclist
       in dir /builder/aarch64_generic/build/sdk (timeout 1200 secs)
       watching logfiles {}
       argv: [b'../../../sha2rsync.pl', b'../../arch-sha256sums', b'bin/packages/aarch64_generic/sha256sums', b'rsynclist']
       environment:
        ...
        PWD=/builder/aarch64_generic/build/sdk
        ...
      Upon execvpe b'../../../sha2rsync.pl' [b'../../../sha2rsync.pl', b'../../arch-sha256sums', b'bin/packages/aarch64_generic/sha256sums', b'rsynclist'] in environment id 139847367136832
      :Traceback (most recent call last):
      ...
      FileNotFoundError: [Errno 2] No such file or directory: b'../../../sha2rsync.pl'
    
    due to relative paths being off by one:
    
     worker work dir = /builder/aarch64_cortex-a72/build
     workerdest = "../sha2rsync.pl"
       is absolute path /builder/aarch64_cortex-a72/sha2rsync.pl
    
    thus relative path from:
    
      FileNotFoundError: [Errno 2] No such file or directory: b'../../../sha2rsync.pl'
    
    in following context:
    
      PWD=/builder/aarch64_generic/build/sdk
      b'../../../sha2rsync.pl'
    
    is wrong absolute path `/builder/sha2rsync.pl` by one directory level,
    thus adjust all those paths accordingly.
    
    Fixes: c3ddb0db167d ("phase2: use sha2rsync.pl for 'targetupload'")
    Signed-off-by: Petr Štetiar <ynezz at true.cz>
---
 phase2/master.cfg | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/phase2/master.cfg b/phase2/master.cfg
index 007bc11..23a67f7 100644
--- a/phase2/master.cfg
+++ b/phase2/master.cfg
@@ -653,7 +653,7 @@ for arch in arches:
 		name = "buildlist",
 		description = "Building list of files to upload",
 		workdir = "build/sdk",
-		command = ["../../../sha2rsync.pl", "../../arch-sha256sums", "bin/packages/%s/sha256sums" %(arch[0]), "rsynclist"],
+		command = ["../../sha2rsync.pl", "../arch-sha256sums", "bin/packages/%s/sha256sums" %(arch[0]), "rsynclist"],
 		haltOnFailure = True,
 	))
 
@@ -671,7 +671,7 @@ for arch in arches:
 		name = "packageupload",
 		description = "Uploading package files",
 		workdir = "build/sdk",
-		command = ["../../../rsync.sh"] + rsync_defopts + ["--files-from=rsynclist", "--delay-updates", "--partial-dir=.~tmp~%s" %(arch[0]), "-a", "bin/packages/%s/" %(arch[0]), Interpolate("%(kw:rsyncbinurl)s/packages%(kw:suffix)s/%(kw:archname)s/", rsyncbinurl=rsync_bin_url, suffix=GetDirectorySuffix, archname=arch[0])],
+		command = ["../../rsync.sh"] + rsync_defopts + ["--files-from=rsynclist", "--delay-updates", "--partial-dir=.~tmp~%s" %(arch[0]), "-a", "bin/packages/%s/" %(arch[0]), Interpolate("%(kw:rsyncbinurl)s/packages%(kw:suffix)s/%(kw:archname)s/", rsyncbinurl=rsync_bin_url, suffix=GetDirectorySuffix, archname=arch[0])],
 		env={'RSYNC_PASSWORD': rsync_bin_key},
 		haltOnFailure = True,
 		logEnviron = False
@@ -681,7 +681,7 @@ for arch in arches:
 		name = "packageprune",
 		description = "Pruning package files",
 		workdir = "build/sdk",
-		command = ["../../../rsync.sh"] + rsync_defopts + ["--delete", "--existing", "--ignore-existing", "--delay-updates", "--partial-dir=.~tmp~%s" %(arch[0]), "-a", "bin/packages/%s/" %(arch[0]), Interpolate("%(kw:rsyncbinurl)s/packages%(kw:suffix)s/%(kw:archname)s/", rsyncbinurl=rsync_bin_url, suffix=GetDirectorySuffix, archname=arch[0])],
+		command = ["../../rsync.sh"] + rsync_defopts + ["--delete", "--existing", "--ignore-existing", "--delay-updates", "--partial-dir=.~tmp~%s" %(arch[0]), "-a", "bin/packages/%s/" %(arch[0]), Interpolate("%(kw:rsyncbinurl)s/packages%(kw:suffix)s/%(kw:archname)s/", rsyncbinurl=rsync_bin_url, suffix=GetDirectorySuffix, archname=arch[0])],
 		env={'RSYNC_PASSWORD': rsync_bin_key},
 		haltOnFailure = True,
 		logEnviron = False
@@ -721,7 +721,7 @@ for arch in arches:
 		name = "logupload",
 		description = "Uploading failure logs",
 		workdir = "build/sdk",
-		command = ["../../../rsync.sh"] + rsync_defopts + ["--delete", "--delay-updates", "--partial-dir=.~tmp~%s" %(arch[0]), "-az", "faillogs/", Interpolate("%(kw:rsyncbinurl)s/faillogs%(kw:suffix)s/%(kw:archname)s/", rsyncbinurl=rsync_bin_url, suffix=GetDirectorySuffix, archname=arch[0])],
+		command = ["../../rsync.sh"] + rsync_defopts + ["--delete", "--delay-updates", "--partial-dir=.~tmp~%s" %(arch[0]), "-az", "faillogs/", Interpolate("%(kw:rsyncbinurl)s/faillogs%(kw:suffix)s/%(kw:archname)s/", rsyncbinurl=rsync_bin_url, suffix=GetDirectorySuffix, archname=arch[0])],
 		env={'RSYNC_PASSWORD': rsync_bin_key},
 		haltOnFailure = False,
 		flunkOnFailure = False,
@@ -742,7 +742,7 @@ for arch in arches:
 			name = "sourceupload",
 			description = "Uploading source archives",
 			workdir = "build/sdk",
-			command = ["../../../rsync.sh"] + rsync_defopts + ["--files-from=sourcelist", "--size-only", "--delay-updates",
+			command = ["../../rsync.sh"] + rsync_defopts + ["--files-from=sourcelist", "--size-only", "--delay-updates",
 					Interpolate("--partial-dir=.~tmp~%(kw:archname)s~%(prop:workername)s", archname=arch[0]), "-a", "dl/", "%s/" %(rsync_src_url)],
 			env={'RSYNC_PASSWORD': rsync_src_key},
 			haltOnFailure = False,




More information about the lede-commits mailing list