[openwrt/openwrt] scripts/dl_github_archive: use tar -I for ZSTD

LEDE Commits lede-commits at lists.infradead.org
Tue Apr 9 09:39:40 PDT 2024


robimarko pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/204823ac287998c8725329ab75333ed1098d3cd8

commit 204823ac287998c8725329ab75333ed1098d3cd8
Author: Robert Marko <robimarko at gmail.com>
AuthorDate: Mon Apr 8 18:38:51 2024 +0200

    scripts/dl_github_archive: use tar -I for ZSTD
    
    Instead of relying on env variables for setting the ZSTD compression
    configuration we can simply do what we do for IB, SDK and the rest and
    use tar -I to pass "zstd -T0 --ultra -20" directly.
    
    This makes it rather clear what is being done and allows to drop the
    zstd CLI max level override as its usually capped at level 19.
    
    Signed-off-by: Robert Marko <robimarko at gmail.com>
---
 scripts/dl_github_archive.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/scripts/dl_github_archive.py b/scripts/dl_github_archive.py
index 744c441ca7..570ed3c629 100755
--- a/scripts/dl_github_archive.py
+++ b/scripts/dl_github_archive.py
@@ -139,9 +139,7 @@ class Path(object):
         if ts is not None:
             args.append('--mtime=@%d' % ts)
         if into.endswith('.zst'):
-            envs['ZSTD_CLEVEL'] = '20'
-            envs['ZSTD_NBTHREADS'] = '0'
-            args.append('--zstd')
+            args.append('-I zstd -T0 --ultra -20')
         elif into.endswith('.xz'):
             envs['XZ_OPT'] = '-7e'
             args.append('-J')




More information about the lede-commits mailing list