[openwrt/openwrt] kernel: allow adding devices without hw offload to a hw flowtable

LEDE Commits lede-commits at lists.infradead.org
Fri Sep 1 06:17:47 PDT 2023


nbd pushed a commit to openwrt/openwrt.git, branch openwrt-23.05:
https://git.openwrt.org/56827dac01b624f769ade541b8b2957fa10ffe79

commit 56827dac01b624f769ade541b8b2957fa10ffe79
Author: Felix Fietkau <nbd at nbd.name>
AuthorDate: Fri Sep 1 12:43:09 2023 +0200

    kernel: allow adding devices without hw offload to a hw flowtable
    
    This allows supporting a mix of devices with or without hw offloading support
    
    Signed-off-by: Felix Fietkau <nbd at nbd.name>
    (cherry picked from commit c5b7be83168644f3cfadc7b0fbe471e1664b1069)
---
 ...f_tables-ignore-EOPNOTSUPP-on-flowtable-d.patch | 29 ++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/target/linux/generic/pending-5.15/701-netfilter-nf_tables-ignore-EOPNOTSUPP-on-flowtable-d.patch b/target/linux/generic/pending-5.15/701-netfilter-nf_tables-ignore-EOPNOTSUPP-on-flowtable-d.patch
new file mode 100644
index 0000000000..ba847d5f8a
--- /dev/null
+++ b/target/linux/generic/pending-5.15/701-netfilter-nf_tables-ignore-EOPNOTSUPP-on-flowtable-d.patch
@@ -0,0 +1,29 @@
+From: Felix Fietkau <nbd at nbd.name>
+Date: Thu, 31 Aug 2023 21:48:38 +0200
+Subject: [PATCH] netfilter: nf_tables: ignore -EOPNOTSUPP on flowtable device
+ offload setup
+
+On many embedded devices, it is common to configure flowtable offloading for
+a mix of different devices, some of which have hardware offload support and
+some of which don't.
+The current code limits the ability of user space to properly set up such a
+configuration by only allowing adding devices with hardware offload support to
+a offload-enabled flowtable.
+Given that offload-enabled flowtables also imply fallback to pure software
+offloading, this limitation makes little sense.
+Fix it by not bailing out when the offload setup returns -EOPNOTSUPP
+
+Signed-off-by: Felix Fietkau <nbd at nbd.name>
+---
+
+--- a/net/netfilter/nf_tables_api.c
++++ b/net/netfilter/nf_tables_api.c
+@@ -7729,7 +7729,7 @@ static int nft_register_flowtable_net_ho
+ 		err = flowtable->data.type->setup(&flowtable->data,
+ 						  hook->ops.dev,
+ 						  FLOW_BLOCK_BIND);
+-		if (err < 0)
++		if (err < 0 && err != -EOPNOTSUPP)
+ 			goto err_unregister_net_hooks;
+ 
+ 		err = nf_register_net_hook(net, &hook->ops);




More information about the lede-commits mailing list