[openwrt/openwrt] CI: check-kernel-patches: use buildbot user on git diff check

LEDE Commits lede-commits at lists.infradead.org
Thu May 25 01:40:11 PDT 2023


dangole pushed a commit to openwrt/openwrt.git, branch openwrt-23.05:
https://git.openwrt.org/bf82648bf74412a364831252d02e708149ef84c7

commit bf82648bf74412a364831252d02e708149ef84c7
Author: Christian Marangi <ansuelsmth at gmail.com>
AuthorDate: Mon May 22 15:27:48 2023 +0200

    CI: check-kernel-patches: use buildbot user on git diff check
    
    Use buildbot user on git diff check instead of using git config
    safe directory.
    
    This should accomplish the same result but should be a better approach
    following safe practice enforced by git.
    
    Fixes: a7747e8670cb ("ci: fix check kernel patches job")
    Signed-off-by: Christian Marangi <ansuelsmth at gmail.com>
    (cherry picked from commit 6c80a578a4428c81fd92e0a2abe95dacfa20c008)
    Signed-off-by: Daniel Golle <daniel at makrotopia.org>
---
 .github/workflows/check-kernel-patches.yml | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/.github/workflows/check-kernel-patches.yml b/.github/workflows/check-kernel-patches.yml
index 4ad35e6250..274bae367d 100644
--- a/.github/workflows/check-kernel-patches.yml
+++ b/.github/workflows/check-kernel-patches.yml
@@ -85,10 +85,6 @@ jobs:
         run: |
           chown -R buildbot:buildbot openwrt
 
-      - name: Opt-out from Git stricter repository ownership checks
-        run: |
-          git config --global --add safe.directory '*'
-
       - name: Initialization environment
         run: |
           TARGET=$(echo ${{ inputs.target }} | cut -d "/" -f 1)
@@ -138,6 +134,7 @@ jobs:
         run: make target/linux/refresh V=s
 
       - name: Validate Refreshed Kernel Patches
+        shell: su buildbot -c "sh -e {0}"
         working-directory: openwrt
         run: |
           . .github/workflows/scripts/ci_helpers.sh




More information about the lede-commits mailing list