[buildbot] phase1: fix crash on exception during Git update
LEDE Commits
lede-commits at lists.infradead.org
Mon May 15 08:39:55 PDT 2023
ynezz pushed a commit to buildbot.git, branch master:
https://git.openwrt.org/2cbc3df5878f49a90f3fa1d595805e422549e0ec
commit 2cbc3df5878f49a90f3fa1d595805e422549e0ec
Author: Petr Štetiar <ynezz at true.cz>
AuthorDate: Mon May 15 16:18:16 2023 +0200
phase1: fix crash on exception during Git update
Fixes following exception:
2023-05-15 14:08:56+0000 [-] <Build master_apm821xx/nand number:1 results:success> build got exception when running step Git(name='git', repourl='https://git.openwrt.org/openwrt/openwrt.git', mode='full', method='fresh', locks=renderer(<function NetLockDl at 0x7f5d33351ee0>), haltOnFailure=True)
2023-05-15 14:08:56+0000 [-] Unhandled Error
Traceback (most recent call last):
File "/usr/local/lib/python3.9/dist-packages/twisted/internet/defer.py", line 1792, in gotResult
_inlineCallbacks(r, gen, status, context)
File "/usr/local/lib/python3.9/dist-packages/twisted/internet/defer.py", line 1693, in _inlineCallbacks
result = context.run(
File "/usr/local/lib/python3.9/dist-packages/twisted/python/failure.py", line 518, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File "/usr/local/lib/python3.9/dist-packages/buildbot/process/build.py", line 576, in _start_next_step_impl
log.err(e)
--- <exception caught here> ---
File "/usr/local/lib/python3.9/dist-packages/buildbot/process/build.py", line 562, in _start_next_step_impl
results = yield step.startStep(self.conn)
builtins.KeyError: None
as None is valid property value, but cant be used as dict index.
Signed-off-by: Petr Štetiar <ynezz at true.cz>
---
phase1/master.cfg | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/phase1/master.cfg b/phase1/master.cfg
index f511e03..c18ee74 100644
--- a/phase1/master.cfg
+++ b/phase1/master.cfg
@@ -142,7 +142,7 @@ def ini_parse_workers(section):
log.msg("invalid worker configuration ignored: {}".format(repr(section)))
return
- sl_props = { 'dl_lock':None, 'ul_lock':None, 'tag_only':tagonly }
+ sl_props = { 'tag_only':tagonly }
if "dl_lock" in section:
lockname = section.get("dl_lock")
sl_props['dl_lock'] = lockname
More information about the lede-commits
mailing list