[openwrt/openwrt] ath79: gpio-latch: fix compilation warning for wrong dev_err %

LEDE Commits lede-commits at lists.infradead.org
Thu May 11 18:25:11 PDT 2023


ansuel pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/4d702a5399dc9d461fc1f0fd566e656f9a7efd48

commit 4d702a5399dc9d461fc1f0fd566e656f9a7efd48
Author: Christian Marangi <ansuelsmth at gmail.com>
AuthorDate: Tue May 9 13:53:25 2023 +0200

    ath79: gpio-latch: fix compilation warning for wrong dev_err %
    
    Fix compilation warning for using %d instead of %ld for gpio-latch in
    dev_err.
    Fix compilation warning:
    In file included from ./include/linux/device.h:15,
                     from ./include/linux/gpio/driver.h:5,
                     from drivers/gpio/gpio-latch.c:13:
    drivers/gpio/gpio-latch.c: In function 'gpio_latch_probe':
    drivers/gpio/gpio-latch.c:137:46: error: format '%d' expects argument of type 'int', but argument 4 has type 'long int' [-Werror=format=]
      137 |                                 dev_err(dev, "failed to get gpio %d: %d\n", i,
          |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ./include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
      110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
          |                              ^~~
    ./include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
      144 |         dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
          |                                                        ^~~~~~~
    drivers/gpio/gpio-latch.c:137:33: note: in expansion of macro 'dev_err'
      137 |                                 dev_err(dev, "failed to get gpio %d: %d\n", i,
          |                                 ^~~~~~~
    drivers/gpio/gpio-latch.c:137:71: note: format string is defined here
      137 |                                 dev_err(dev, "failed to get gpio %d: %d\n", i,
          |                                                                      ~^
          |                                                                       |
          |                                                                       int
          |                                                                      %ld
    cc1: all warnings being treated as errors
    
    Signed-off-by: Christian Marangi <ansuelsmth at gmail.com>
---
 target/linux/ath79/files/drivers/gpio/gpio-latch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/ath79/files/drivers/gpio/gpio-latch.c b/target/linux/ath79/files/drivers/gpio/gpio-latch.c
index 976e683230..68f9290b2a 100644
--- a/target/linux/ath79/files/drivers/gpio/gpio-latch.c
+++ b/target/linux/ath79/files/drivers/gpio/gpio-latch.c
@@ -134,7 +134,7 @@ static int gpio_latch_probe(struct platform_device *pdev)
 			GPIOD_OUT_LOW);
 		if (IS_ERR(glc->gpios[i])) {
 			if (PTR_ERR(glc->gpios[i]) != -EPROBE_DEFER) {
-				dev_err(dev, "failed to get gpio %d: %d\n", i,
+				dev_err(dev, "failed to get gpio %d: %ld\n", i,
 					PTR_ERR(glc->gpios[i]));
 			}
 			return PTR_ERR(glc->gpios[i]);




More information about the lede-commits mailing list