[openwrt/openwrt] realtek: 5.15: replace fallthrough comment for rtl838x ethernet driver

LEDE Commits lede-commits at lists.infradead.org
Thu May 11 18:25:05 PDT 2023


ansuel pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/c7bca5883d17ad49c66e7acd671c2c2a3d0ea6fc

commit c7bca5883d17ad49c66e7acd671c2c2a3d0ea6fc
Author: Christian Marangi <ansuelsmth at gmail.com>
AuthorDate: Sun May 7 10:20:30 2023 +0200

    realtek: 5.15: replace fallthrough comment for rtl838x ethernet driver
    
    Replace fallthrough comment with fallthrough macro for rtl838x ethernet
    driver.
    Fix compilarion warning:
    drivers/net/ethernet/rtl838x_eth.c: In function 'rtl930x_mdio_reset':
    drivers/net/ethernet/rtl838x_eth.c:1959:43: error: this statement may fall through [-Werror=implicit-fallthrough=]
     1959 |                         private_poll_mask |= BIT(i);
    drivers/net/ethernet/rtl838x_eth.c:1961:17: note: here
     1961 |                 case PHY_INTERFACE_MODE_USXGMII:
          |                 ^~~~
    
    Signed-off-by: Christian Marangi <ansuelsmth at gmail.com>
---
 target/linux/realtek/files-5.15/drivers/net/ethernet/rtl838x_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/realtek/files-5.15/drivers/net/ethernet/rtl838x_eth.c b/target/linux/realtek/files-5.15/drivers/net/ethernet/rtl838x_eth.c
index 06de0ada2a..e9ebc7c73c 100644
--- a/target/linux/realtek/files-5.15/drivers/net/ethernet/rtl838x_eth.c
+++ b/target/linux/realtek/files-5.15/drivers/net/ethernet/rtl838x_eth.c
@@ -1958,7 +1958,7 @@ static int rtl930x_mdio_reset(struct mii_bus *bus)
 			break;			/* Serdes: Value = 0 */
 		case PHY_INTERFACE_MODE_HSGMII:
 			private_poll_mask |= BIT(i);
-			/* fallthrough */
+			fallthrough;
 		case PHY_INTERFACE_MODE_USXGMII:
 			v |= BIT(mac_type_bit[i]);
 			uses_usxgmii = true;




More information about the lede-commits mailing list