[openwrt/openwrt] ralink: mt7620: fix compilation warning for device_reset in i2s driver

LEDE Commits lede-commits at lists.infradead.org
Thu May 11 18:24:56 PDT 2023


ansuel pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/aa7a2d971e5117216dca6cd0d7c41efa9235b0e6

commit aa7a2d971e5117216dca6cd0d7c41efa9235b0e6
Author: Christian Marangi <ansuelsmth at gmail.com>
AuthorDate: Sat May 6 23:08:36 2023 +0200

    ralink: mt7620: fix compilation warning for device_reset in i2s driver
    
    Fix compilation warning for device_reset in i2s driver.
    Fix compilation warning:
    sound/soc/ralink/ralink-i2s.c: In function 'ralink_i2s_probe':
    sound/soc/ralink/ralink-i2s.c:885:9: error: ignoring return value of 'device_reset' declared with attribute 'warn_unused_result' [-Werror=unused-result]
      885 |         device_reset(&pdev->dev);
          |         ^~~~~~~~~~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errorralink: mt7620: fix compilation
    warning for device_reset in i2s driver
    
    Signed-off-by: Christian Marangi <ansuelsmth at gmail.com>
---
 .../linux/ramips/patches-5.15/835-asoc-add-mt7620-support.patch   | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/target/linux/ramips/patches-5.15/835-asoc-add-mt7620-support.patch b/target/linux/ramips/patches-5.15/835-asoc-add-mt7620-support.patch
index 633c5120e0..551fdd8b3c 100644
--- a/target/linux/ramips/patches-5.15/835-asoc-add-mt7620-support.patch
+++ b/target/linux/ramips/patches-5.15/835-asoc-add-mt7620-support.patch
@@ -60,7 +60,7 @@ Signed-off-by: John Crispin <blogic at openwrt.org>
 +obj-$(CONFIG_SND_RALINK_SOC_I2S) += snd-soc-ralink-i2s.o
 --- /dev/null
 +++ b/sound/soc/ralink/ralink-i2s.c
-@@ -0,0 +1,966 @@
+@@ -0,0 +1,970 @@
 +/*
 + *  Copyright (C) 2010, Lars-Peter Clausen <lars at metafoo.de>
 + *  Copyright (C) 2016 Michael Lee <igvtee at gmail.com>
@@ -945,7 +945,11 @@ Signed-off-by: John Crispin <blogic at openwrt.org>
 +
 +	ralink_i2s_init_dma_data(i2s, res);
 +
-+	device_reset(&pdev->dev);
++	ret = device_reset(&pdev->dev);
++	if (ret) {
++		dev_err(&pdev->dev, "failed to reset device\n");
++		goto err_clk_disable;
++	}
 +
 +	ret = ralink_i2s_debugfs_create(i2s);
 +	if (ret) {




More information about the lede-commits mailing list