[openwrt/openwrt] tools: Improve diffability/maintainability

LEDE Commits lede-commits at lists.infradead.org
Tue Jan 17 12:38:48 PST 2023


ansuel pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/92feae64eb8d3a315fb0aa311b3fac9818a51505

commit 92feae64eb8d3a315fb0aa311b3fac9818a51505
Author: Olliver Schinagl <oliver at schinagl.nl>
AuthorDate: Tue Jan 17 20:54:05 2023 +0100

    tools: Improve diffability/maintainability
    
    Like with commit ae614fb397c2 ("tools: Improve diffability/maintainability")
    we also want tools-core to be easy to maintain. While a smaller target,
    it's still usefull and makes things nice and consistent.
    
    To avoid duplicating any tools in the comment, simplify the comment
    instead.
    
    Signed-off-by: Olliver Schinagl <oliver at schinagl.nl>
---
 tools/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tools/Makefile b/tools/Makefile
index a8044dcf1f..7ca874aa91 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -147,8 +147,10 @@ $(foreach tool, $(tools-y), $(if $(wildcard $(curdir)/$(tool)/patches),$(eval $(
 
 $(foreach tool, $(filter-out xz,$(tools-y)), $(eval $(curdir)/$(tool)/compile += $(curdir)/xz/compile))
 
-# make any tool depend on tar, xz and patch to ensure that archives can be unpacked and patched properly
-tools-core := tar xz patch
+# make any tool depend on the following to ensure that archives can be unpacked and patched properly
+tools-core += patch
+tools-core += tar
+tools-core += xz
 
 $(foreach tool, $(tools-y), $(eval $(curdir)/$(tool)/compile += $(patsubst %,$(curdir)/%/compile,$(tools-core))))
 tools-y += $(tools-core)




More information about the lede-commits mailing list