[openwrt/openwrt] mvebu/uDPU: add quotes to unmount file

LEDE Commits lede-commits at lists.infradead.org
Fri Feb 3 02:36:13 PST 2023


hauke pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/822c554d5755301337bce959554bf973b4292322

commit 822c554d5755301337bce959554bf973b4292322
Author: Rosen Penev <rosenp at gmail.com>
AuthorDate: Sat Aug 20 14:10:21 2022 -0700

    mvebu/uDPU: add quotes to unmount file
    
    This is the last relevant shellcheck warning thrown.
    
    Signed-off-by: Rosen Penev <rosenp at gmail.com>
---
 target/linux/mvebu/cortexa53/base-files/lib/upgrade/uDPU.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/linux/mvebu/cortexa53/base-files/lib/upgrade/uDPU.sh b/target/linux/mvebu/cortexa53/base-files/lib/upgrade/uDPU.sh
index 92102e8d14..b01ad607ee 100644
--- a/target/linux/mvebu/cortexa53/base-files/lib/upgrade/uDPU.sh
+++ b/target/linux/mvebu/cortexa53/base-files/lib/upgrade/uDPU.sh
@@ -20,7 +20,7 @@ udpu_check_emmc() {
 udpu_part_prep() {
 	 if grep -q "$1" /proc/mounts; then
 		mounted_part="$(grep -m 1 $1 /proc/mounts | awk '{print $2}')"
-		umount $mounted_part
+		umount "$mounted_part"
 		grep -woq "$mounted_part" /proc/mounts && umount -l "$mounted_part"
 	fi
 }
@@ -143,7 +143,7 @@ platform_do_upgrade_uDPU() {
 	# Remove tmp mounts
 	tmp_parts=$(grep "${emmc_dev}" /proc/mounts | awk '{print $2}')
 	for part in ${tmp_parts}; do
-		umount $part
+		umount "$part"
 		# Force umount is necessary
 		grep -q "${part}" /proc/mounts && umount -l "$part"
 	done




More information about the lede-commits mailing list