[openwrt/openwrt] base-files: Actually set default name

LEDE Commits lede-commits at lists.infradead.org
Thu Sep 22 12:41:16 PDT 2022


ansuel pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/211f4302e4f64e84e2895c6ed55fc1f43da56528

commit 211f4302e4f64e84e2895c6ed55fc1f43da56528
Author: Olliver Schinagl <oliver at schinagl.nl>
AuthorDate: Wed Sep 21 17:57:53 2022 +0200

    base-files: Actually set default name
    
    The currently used shell expansion doesn't seem to exist [0] and also
    does not work. This surely was not intended, so lets allow default
    naming to actually work.
    
    [0]: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html
    
    Fixes: be09c5a3cd65 ("base-files: add board.d support for bridge device")
    Signed-off-by: Olliver Schinagl <oliver at schinagl.nl>
---
 package/base-files/files/lib/functions/uci-defaults.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/base-files/files/lib/functions/uci-defaults.sh b/package/base-files/files/lib/functions/uci-defaults.sh
index 4f5b9634bb..86f16b5125 100644
--- a/package/base-files/files/lib/functions/uci-defaults.sh
+++ b/package/base-files/files/lib/functions/uci-defaults.sh
@@ -96,7 +96,7 @@ ucidef_set_interfaces_lan_wan() {
 
 ucidef_set_bridge_device() {
 	json_select_object bridge
-	json_add_string name "${1:switch0}"
+	json_add_string name "${1:-switch0}"
 	json_select ..
 }
 




More information about the lede-commits mailing list