[openwrt/openwrt] mediatek: correctly log i2c response

LEDE Commits lede-commits at lists.infradead.org
Sun Sep 18 19:13:28 PDT 2022


dangole pushed a commit to openwrt/openwrt.git, branch openwrt-22.03:
https://git.openwrt.org/a2d251573b382ac3466ce94af96a102c943cae2d

commit a2d251573b382ac3466ce94af96a102c943cae2d
Author: Sven Wegener <sven.wegener at stealer.net>
AuthorDate: Sat Jun 12 21:56:21 2021 +0200

    mediatek: correctly log i2c response
    
    The read response is in the i2c_response variable. Also use %hhx format,
    because we're dealing with a single char.
    
    Signed-off-by: Sven Wegener <sven.wegener at stealer.net>
    (cherry picked from commit c4f9f9b44c82ffeacd9d3c00ba07171c35831337)
---
 target/linux/mediatek/files-5.10/drivers/leds/leds-ubnt-ledbar.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/linux/mediatek/files-5.10/drivers/leds/leds-ubnt-ledbar.c b/target/linux/mediatek/files-5.10/drivers/leds/leds-ubnt-ledbar.c
index 9f12cda5d1..9bfe0e62f4 100644
--- a/target/linux/mediatek/files-5.10/drivers/leds/leds-ubnt-ledbar.c
+++ b/target/linux/mediatek/files-5.10/drivers/leds/leds-ubnt-ledbar.c
@@ -74,14 +74,14 @@ static int ubnt_ledbar_apply_state(struct ubnt_ledbar *ledbar)
 
 	i2c_response = ubnt_ledbar_perform_transaction(ledbar, setup_msg);
 	if (i2c_response != UBNT_LEDBAR_TRANSACTION_SUCCESS) {
-		dev_err(&ledbar->client->dev, "Error initializing LED transaction: %02x\n", ret);
+		dev_err(&ledbar->client->dev, "Error initializing LED transaction: %02hhx\n", i2c_response);
 		ret = -EINVAL;
 		goto out_gpio;
 	}
 
 	i2c_response = ubnt_ledbar_perform_transaction(ledbar, led_msg);
 	if (i2c_response != UBNT_LEDBAR_TRANSACTION_SUCCESS) {
-		dev_err(&ledbar->client->dev, "Failed LED transaction: %02x\n", ret);
+		dev_err(&ledbar->client->dev, "Failed LED transaction: %02hhx\n", i2c_response);
 		ret = -EINVAL;
 		goto out_gpio;
 	}




More information about the lede-commits mailing list