[openwrt/openwrt] realtek: rtl838x: Fix ethernet polling timeout on probe

LEDE Commits lede-commits at lists.infradead.org
Wed Sep 14 09:25:17 PDT 2022


ansuel pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/c4d030f24cff34737d7cf1f116022b8dbe45f5be

commit c4d030f24cff34737d7cf1f116022b8dbe45f5be
Author: Olliver Schinagl <oliver at schinagl.nl>
AuthorDate: Wed Aug 31 17:20:52 2022 +0200

    realtek: rtl838x: Fix ethernet polling timeout on probe
    
    Due to an oversight we accidentally inverted the timeout check. This
    patch corrects this.
    
    Fixes: 9cec4a0ea45b ("realtek: Use built-in functionality for timeout loop")
    Signed-off-by: Olliver Schinagl <oliver at schinagl.nl>
    [ wrap poll_timeout line to 80 char ]
    Signed-off-by: Christian Marangi <ansuelsmth at gmail.com>
---
 target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/rtl838x.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/rtl838x.c b/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/rtl838x.c
index f56901d707..76b6cde7be 100644
--- a/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/rtl838x.c
+++ b/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/rtl838x.c
@@ -1809,7 +1809,8 @@ int rtl838x_smi_wait_op(int timeout)
 	int ret = 0;
 	u32 val;
 
-	ret = readx_poll_timeout(sw_r32, RTL838X_SMI_ACCESS_PHY_CTRL_1, val, val & 0x1, 20, timeout);
+	ret = readx_poll_timeout(sw_r32, RTL838X_SMI_ACCESS_PHY_CTRL_1,
+				 val, !(val & 0x1), 20, timeout);
 	if (ret)
 		pr_err("%s: timeout\n", __func__);
 




More information about the lede-commits mailing list