[openwrt/openwrt] gettext-full: add gmsgfmt symlink in host install

LEDE Commits lede-commits at lists.infradead.org
Fri Mar 25 09:24:29 PDT 2022


stintel pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/636cb00ecc8d693c36e48952f6d154f91e0e569e

commit 636cb00ecc8d693c36e48952f6d154f91e0e569e
Author: Stijn Tintel <stijn at linux-ipv6.be>
AuthorDate: Fri Mar 25 15:03:53 2022 +0200

    gettext-full: add gmsgfmt symlink in host install
    
    Some configure scripts look for msgfmt and gmsgfmt. As we don't install
    the latter, configure might pick up one from staging_dir/hostpkg, and
    the other from the host:
    
    checking for msgfmt... /home/stijn/Development/OpenWrt/openwrt/staging_dir/hostpkg/bin/msgfmt
    checking for gmsgfmt... /usr/bin/gmsgfmt
    
    This could potentially lead to hard to debug undefined behaviour.
    Install a symlink in the host install phase to avoid this.
    
    Signed-off-by: Stijn Tintel <stijn at linux-ipv6.be>
---
 package/libs/gettext-full/Makefile | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/libs/gettext-full/Makefile b/package/libs/gettext-full/Makefile
index 6a97fd5b91..f5f5e00542 100644
--- a/package/libs/gettext-full/Makefile
+++ b/package/libs/gettext-full/Makefile
@@ -88,6 +88,11 @@ define Build/InstallDev
 	$(SED) '/read dummy/d' $(STAGING_DIR_HOSTPKG)/bin/gettextize
 endef
 
+define Host/Install
+	$(call Host/Install/Default)
+	$(LN) msgfmt $(STAGING_DIR_HOSTPKG)/bin/gmsgfmt
+endef
+
 define Package/libintl-full/install
 	$(INSTALL_DIR) $(1)/usr/lib
 	$(CP) $(PKG_INSTALL_DIR)/usr/lib/libintl.so.* $(1)/usr/lib/




More information about the lede-commits mailing list