[openwrt/openwrt] build: fix find warning with SCAN_EXTRA

LEDE Commits lede-commits at lists.infradead.org
Tue Jun 7 14:02:45 PDT 2022


hauke pushed a commit to openwrt/openwrt.git, branch openwrt-22.03:
https://git.openwrt.org/720a7db7eaf416f7e4abdde1551d0201e7830310

commit 720a7db7eaf416f7e4abdde1551d0201e7830310
Author: Leo Chung <gewalalb at gmail.com>
AuthorDate: Thu Mar 31 09:14:35 2022 +0800

    build: fix find warning with SCAN_EXTRA
    
    If you change SCAN_EXTRA variable with "-path target/linux/xxxx" in
    include/toplevel.mk for speed up scan, find will warn with:
    
    find: warning: you have specified the global option -maxdepth after
    the argument -path, but global options are not positional, i.e.,
    -maxdepth affects tests specified before it as well as those specified
    after it.  Please specify global options before other arguments.
    
    The find option -mindepth -maxdepth are global options and must be
    before any path option. Change order of $(SCAN_EXTRA) after -mindepth
    and -maxdepth to fix this.
    
    Signed-off-by: Leo Chung <gewalalb at gmail.com>
    [capitalize Description, Author and Sob and minor description tweak]
    Signed-off-by: Christian 'Ansuel' Marangi <ansuelsmth at gmail.com>
    (cherry picked from commit eb787b5b9d8d45f3678b58eaa158bb4fa28d4418)
---
 include/scan.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/scan.mk b/include/scan.mk
index aee24cb3e5..5032afa818 100644
--- a/include/scan.mk
+++ b/include/scan.mk
@@ -72,7 +72,7 @@ endif
 
 $(FILELIST): $(OVERRIDELIST)
 	rm -f $(TMP_DIR)/info/.files-$(SCAN_TARGET)-*
-	find -L $(SCAN_DIR) $(SCAN_EXTRA) -mindepth 1 $(if $(SCAN_DEPTH),-maxdepth $(SCAN_DEPTH)) -name Makefile | xargs grep -aHE 'call $(GREP_STRING)' | sed -e 's#^$(SCAN_DIR)/##' -e 's#/Makefile:.*##' | uniq | awk -v of=$(OVERRIDELIST) -f include/scan.awk > $@
+	find -L $(SCAN_DIR) -mindepth 1 $(if $(SCAN_DEPTH),-maxdepth $(SCAN_DEPTH)) $(SCAN_EXTRA) -name Makefile | xargs grep -aHE 'call $(GREP_STRING)' | sed -e 's#^$(SCAN_DIR)/##' -e 's#/Makefile:.*##' | uniq | awk -v of=$(OVERRIDELIST) -f include/scan.awk > $@
 
 $(TMP_DIR)/info/.files-$(SCAN_TARGET).mk: $(FILELIST)
 	( \




More information about the lede-commits mailing list