[openwrt/openwrt] realtek: remove hardcoded sys-led configurations

LEDE Commits lede-commits at lists.infradead.org
Sun Jul 10 01:05:54 PDT 2022


svanheule pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/eae5e55a7938504691f8be27665c6fa3935a01d9

commit eae5e55a7938504691f8be27665c6fa3935a01d9
Author: Sander Vanheule <sander at svanheule.net>
AuthorDate: Fri Nov 26 22:16:47 2021 +0100

    realtek: remove hardcoded sys-led configurations
    
    setup.c unconditionally sets the sys-led mode (blinking rate) to a
    permanent high output. This may cause issues when a board expects this
    pin to toggle periodically, e.g. when hooked up to an external watchdog.
    
    If the sys-led peripheral is used to control an LED, the mux should be
    configured to use the pin as GPIO0, allowing for better control as a
    GPIO LED.
    
    Signed-off-by: Sander Vanheule <sander at svanheule.net>
---
 .../realtek/files-5.10/arch/mips/rtl838x/setup.c   | 40 ----------------------
 1 file changed, 40 deletions(-)

diff --git a/target/linux/realtek/files-5.10/arch/mips/rtl838x/setup.c b/target/linux/realtek/files-5.10/arch/mips/rtl838x/setup.c
index 18c477eb0f..e0adbf87e9 100644
--- a/target/linux/realtek/files-5.10/arch/mips/rtl838x/setup.c
+++ b/target/linux/realtek/files-5.10/arch/mips/rtl838x/setup.c
@@ -28,31 +28,6 @@
 
 extern struct rtl83xx_soc_info soc_info;
 
-static void __init rtl838x_setup(void)
-{
-	/* Setup System LED. Bit 15 then allows to toggle it */
-	sw_w32_mask(0, 3 << 16, RTL838X_LED_GLB_CTRL);
-}
-
-static void __init rtl839x_setup(void)
-{
-	/* Setup System LED. Bit 14 of RTL839X_LED_GLB_CTRL then allows to toggle it */
-	sw_w32_mask(0, 3 << 15, RTL839X_LED_GLB_CTRL);
-}
-
-static void __init rtl930x_setup(void)
-{
-	if (soc_info.id == 0x9302)
-		sw_w32_mask(0, 3 << 13, RTL9302_LED_GLB_CTRL);
-	else
-		sw_w32_mask(0, 3 << 13, RTL930X_LED_GLB_CTRL);
-}
-
-static void __init rtl931x_setup(void)
-{
-	sw_w32_mask(0, 3 << 12, RTL931X_LED_GLB_CTRL);
-}
-
 void __init plat_mem_setup(void)
 {
 	void *dtb;
@@ -71,21 +46,6 @@ void __init plat_mem_setup(void)
 	 * parsed resulting in our memory appearing
 	 */
 	__dt_setup_arch(dtb);
-
-	switch (soc_info.family) {
-	case RTL8380_FAMILY_ID:
-		rtl838x_setup();
-		break;
-	case RTL8390_FAMILY_ID:
-		rtl839x_setup();
-		break;
-	case RTL9300_FAMILY_ID:
-		rtl930x_setup();
-		break;
-	case RTL9310_FAMILY_ID:
-		rtl931x_setup();
-		break;
-	}
 }
 
 void __init plat_time_init(void)




More information about the lede-commits mailing list