[openwrt/openwrt] image-commands.mk: Use ERROR_MESSAGE for imagesize fails

LEDE Commits lede-commits at lists.infradead.org
Mon Feb 28 14:52:17 PST 2022


aparcar pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/a9478490d86e16f130f12fe5394ee484dcf13822

commit a9478490d86e16f130f12fe5394ee484dcf13822
Author: Paul Spooren <mail at aparcar.org>
AuthorDate: Mon Feb 28 10:20:53 2022 +0100

    image-commands.mk: Use ERROR_MESSAGE for imagesize fails
    
    If a image is bigger than the device can handle, an error message is
    printed. This is usually silenced and silently ignored, making it harder
    to debug. While it's possible to run the build in verbose mode (via
    `make V=s`) and grep for *is too big*, it's more intuitive to print the
    error message directly. For that use the newly unlocked `$(call
    ERROR_MESSAGE,...)` definition which now also print in non-verbose mode.
    
    Fixes: FS#50 (aka #7604)
    
    Signed-off-by: Paul Spooren <mail at aparcar.org>
---
 include/image-commands.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/image-commands.mk b/include/image-commands.mk
index 485d870f05..939f5ef2db 100644
--- a/include/image-commands.mk
+++ b/include/image-commands.mk
@@ -191,7 +191,7 @@ define Build/check-size
 	@imagesize="$$(stat -c%s $@)"; \
 	limitsize="$$(($(subst k,* 1024,$(subst m, * 1024k,$(if $(1),$(1),$(IMAGE_SIZE))))))"; \
 	[ $$limitsize -ge $$imagesize ] || { \
-		echo "WARNING: Image file $@ is too big: $$imagesize > $$limitsize" >&2; \
+		$(call ERROR_MESSAGE,    WARNING: Image file $@ is too big: $$imagesize > $$limitsize); \
 		rm -f $@; \
 	}
 endef




More information about the lede-commits mailing list