[openwrt/openwrt] realtek: fix default image generation

LEDE Commits lede-commits at lists.infradead.org
Wed Dec 28 13:54:20 PST 2022


svanheule pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/ab8a5f2ea0e15e69a1f5e14642034eb75b2317fd

commit ab8a5f2ea0e15e69a1f5e14642034eb75b2317fd
Author: Sander Vanheule <sander at svanheule.net>
AuthorDate: Wed Dec 28 21:46:48 2022 +0100

    realtek: fix default image generation
    
    While cleaning up the makefiles for the realtek target, the order of the
    default image generating commands was accidentally changed. This caused
    the image signature to end up somewhere in the middle, misaligning the
    rootfs. As a result, sysupgrade couldn't verify upgrade images anymore,
    and devices end up in a boot loop due to the unaligned (and not found)
    rootfs.
    
    Fixes: 94d8b4852b9f ("realtek: Cleanup Makefiles")
    Signed-off-by: Sander Vanheule <sander at svanheule.net>
---
 target/linux/realtek/image/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/target/linux/realtek/image/Makefile b/target/linux/realtek/image/Makefile
index e4a3904aa8..66d7ee4895 100644
--- a/target/linux/realtek/image/Makefile
+++ b/target/linux/realtek/image/Makefile
@@ -102,11 +102,11 @@ define Device/Default
   IMAGES := sysupgrade.bin
   IMAGE/sysupgrade.bin := \
 	append-kernel | \
-	append-metadata | \
+	pad-to 64k | \
 	append-rootfs | \
-	check-size | \
 	pad-rootfs | \
-	pad-to 64k
+	check-size | \
+	append-metadata
 endef
 
 include $(SUBTARGET).mk




More information about the lede-commits mailing list