[openwrt/openwrt] ipq806x: ecw5410: drop GPIO based MDIO1 node

LEDE Commits lede-commits at lists.infradead.org
Sun Oct 31 16:16:49 PDT 2021


adrian pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/fa3646c0033eb93d6397b55c1a4e921dff1049f8

commit fa3646c0033eb93d6397b55c1a4e921dff1049f8
Author: Robert Marko <robert.marko at sartura.hr>
AuthorDate: Sun Oct 31 11:38:31 2021 +0100

    ipq806x: ecw5410: drop GPIO based MDIO1 node
    
    It looks like this is a leftover before there was a proper MDIO driver.
    Since both PHY-s are connected to the HW MDIO bus there is no reason for
    this to exist anymore, especially since it uses the same pins as the HW
    controller and has the pinmux for the set to "MDIO" so this worked by
    pure luck as GPIO MDIO would probe first and override the HW driver.
    
    Move the GMAC3 to simply use the same MDIO bus phandle.
    
    Signed-off-by: Robert Marko <robert.marko at sartura.hr>
---
 .../arch/arm/boot/dts/qcom-ipq8068-ecw5410.dts     | 29 ++++++++--------------
 1 file changed, 10 insertions(+), 19 deletions(-)

diff --git a/target/linux/ipq806x/files/arch/arm/boot/dts/qcom-ipq8068-ecw5410.dts b/target/linux/ipq806x/files/arch/arm/boot/dts/qcom-ipq8068-ecw5410.dts
index 43bed451cb..57724c19d7 100644
--- a/target/linux/ipq806x/files/arch/arm/boot/dts/qcom-ipq8068-ecw5410.dts
+++ b/target/linux/ipq806x/files/arch/arm/boot/dts/qcom-ipq8068-ecw5410.dts
@@ -34,7 +34,6 @@
 
 	aliases {
 		serial1 = &gsbi1_serial;
-		mdio-gpio0 = &mdio0;
 		ethernet0 = &gmac3;
 		ethernet1 = &gmac2;
 
@@ -293,26 +292,18 @@
 	};
 };
 
-&soc {
-	mdio1: mdio {
-		compatible = "virtual,mdio-gpio";
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		status = "okay";
-
-		pinctrl-0 = <&mdio0_pins>;
-		pinctrl-names = "default";
+&mdio0 {
+	status = "okay";
 
-		gpios = <&qcom_pinmux 1 GPIO_ACTIVE_HIGH &qcom_pinmux 0 GPIO_ACTIVE_HIGH>;
+	pinctrl-0 = <&mdio0_pins>;
+	pinctrl-names = "default";
 
-		phy0: ethernet-phy at 0 {
-			reg = <0>;
-		};
+	phy0: ethernet-phy at 0 {
+		reg = <0>;
+	};
 
-		phy1: ethernet-phy at 1 {
-			reg = <1>;
-		};
+	phy1: ethernet-phy at 1 {
+		reg = <1>;
 	};
 };
 
@@ -330,7 +321,7 @@
 	status = "okay";
 
 	qcom,id = <3>;
-	mdiobus = <&mdio1>;
+	mdiobus = <&mdio0>;
 
 	phy-mode = "sgmii";
 	phy-handle = <&phy0>;



More information about the lede-commits mailing list