[openwrt/openwrt] layerscape: mkits-multiple-config: fail on invalid arguments
LEDE Commits
lede-commits at lists.infradead.org
Mon Nov 8 07:00:18 PST 2021
rmilecki pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/b8bbac951c42c6639a66696ade4477aa2be6aa54
commit b8bbac951c42c6639a66696ade4477aa2be6aa54
Author: Rafał Miłecki <rafal at milecki.pl>
AuthorDate: Mon Oct 25 10:17:15 2021 +0200
layerscape: mkits-multiple-config: fail on invalid arguments
Fail if arguments couldn't be parsed and print unrecognized part. It's
important when running it from script with dynamic values. Missing value
could result in skipping argument and silent failures (unexpected its).
Signed-off-by: Rafał Miłecki <rafal at milecki.pl>
---
target/linux/layerscape/image/mkits-multiple-config.sh | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/target/linux/layerscape/image/mkits-multiple-config.sh b/target/linux/layerscape/image/mkits-multiple-config.sh
index 68870686c5..b2d8f4ef7f 100755
--- a/target/linux/layerscape/image/mkits-multiple-config.sh
+++ b/target/linux/layerscape/image/mkits-multiple-config.sh
@@ -198,6 +198,11 @@ parse_args() {
usage;;
esac
done
+ shift $(($OPTIND - 1))
+ [ $# -gt 0 ] && {
+ echo "Failed to parse all passed arguments (unrecognized: \"$@\")"
+ exit 1
+ }
[ -n "${OUTPUT}" ] || OUTPUT=fitimage.its
[ -n "${VERSION}" ] || VERSION="Unknown"
[ -n "${ARCH}" ] || ARCH=arm
More information about the lede-commits
mailing list