[openwrt/openwrt] hostapd: avoid unnecessary package rebuilds

LEDE Commits lede-commits at lists.infradead.org
Tue Nov 2 01:57:08 PDT 2021


nbd pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/67f9245ee57eaf47093275670b227c7911f485d4

commit 67f9245ee57eaf47093275670b227c7911f485d4
Author: Eneas U de Queiroz <cotequeiroz at gmail.com>
AuthorDate: Fri Oct 15 13:39:19 2021 -0300

    hostapd: avoid unnecessary package rebuilds
    
    Package hostapd-common is a dependency of every other package defined in
    hostpad Makefile.  It is currently built next to the bottom of that
    Makefile's package list.
    
    If you run make back to back, then check-compile will compare the
    hostapd-common timestamp to the variant being compiled, to decide if the
    varint needs to be rebuilt or not.  Since the hostapd-conf package is
    built towards the end of the list, it will be newer than most of the
    variants, causing unnecessary package rebuilds.
    
    Move it to the top, so that its timestamp will be older than dependent
    packages, avoiding unnecessary rebuild of every selected variant.
    
    Signed-off-by: Eneas U de Queiroz <cotequeiroz at gmail.com>
---
 package/network/services/hostapd/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/network/services/hostapd/Makefile b/package/network/services/hostapd/Makefile
index fee6889b40..4930851780 100644
--- a/package/network/services/hostapd/Makefile
+++ b/package/network/services/hostapd/Makefile
@@ -677,6 +677,9 @@ ifeq ($(BUILD_VARIANT),supplicant-full-wolfssl)
   endef
 endif
 
+# Build hostapd-common before its dependents, to avoid
+# spurious rebuilds when building multiple variants.
+$(eval $(call BuildPackage,hostapd-common))
 $(eval $(call BuildPackage,hostapd))
 $(eval $(call BuildPackage,hostapd-basic))
 $(eval $(call BuildPackage,hostapd-basic-openssl))
@@ -703,7 +706,6 @@ $(eval $(call BuildPackage,wpa-supplicant-openssl))
 $(eval $(call BuildPackage,wpa-supplicant-wolfssl))
 $(eval $(call BuildPackage,wpa-cli))
 $(eval $(call BuildPackage,hostapd-utils))
-$(eval $(call BuildPackage,hostapd-common))
 $(eval $(call BuildPackage,eapol-test))
 $(eval $(call BuildPackage,eapol-test-openssl))
 $(eval $(call BuildPackage,eapol-test-wolfssl))



More information about the lede-commits mailing list