[openwrt/openwrt] mac80211: fix queue assignment of aggregation start requests

LEDE Commits lede-commits at lists.infradead.org
Thu Dec 2 05:53:46 PST 2021


nbd pushed a commit to openwrt/openwrt.git, branch openwrt-21.02:
https://git.openwrt.org/b1e684fa88c171032e2da5437a507b63bf18d9e1

commit b1e684fa88c171032e2da5437a507b63bf18d9e1
Author: Felix Fietkau <nbd at nbd.name>
AuthorDate: Thu Dec 2 13:52:18 2021 +0100

    mac80211: fix queue assignment of aggregation start requests
    
    Signed-off-by: Felix Fietkau <nbd at nbd.name>
    (cherry-picked from commit 15d8c7aa74c202c530dbd53e53b00e418f0b64f4)
---
 ...nd-ADDBA-requests-using-the-tid-queue-of-.patch | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/package/kernel/mac80211/patches/subsys/308-mac80211-send-ADDBA-requests-using-the-tid-queue-of-.patch b/package/kernel/mac80211/patches/subsys/308-mac80211-send-ADDBA-requests-using-the-tid-queue-of-.patch
new file mode 100644
index 0000000000..1c213289c5
--- /dev/null
+++ b/package/kernel/mac80211/patches/subsys/308-mac80211-send-ADDBA-requests-using-the-tid-queue-of-.patch
@@ -0,0 +1,28 @@
+From: Felix Fietkau <nbd at nbd.name>
+Date: Thu, 2 Dec 2021 13:30:05 +0100
+Subject: [PATCH] mac80211: send ADDBA requests using the tid/queue of the
+ aggregation session
+
+Sending them out on a different queue can cause a race condition where a
+number of packets in the queue may be discarded by the receiver, because
+the ADDBA request is sent too early.
+This affects any driver with software A-MPDU setup which does not allocate
+packet seqno in hardware on tx, regardless of whether iTXQ is used or not.
+The only driver I've seen that explicitly deals with this issue internally
+is mwl8k.
+
+Cc: stable at vger.kernel.org
+Signed-off-by: Felix Fietkau <nbd at nbd.name>
+---
+
+--- a/net/mac80211/agg-tx.c
++++ b/net/mac80211/agg-tx.c
+@@ -106,7 +106,7 @@ static void ieee80211_send_addba_request
+ 	mgmt->u.action.u.addba_req.start_seq_num =
+ 					cpu_to_le16(start_seq_num << 4);
+ 
+-	ieee80211_tx_skb(sdata, skb);
++	ieee80211_tx_skb_tid(sdata, skb, tid);
+ }
+ 
+ void ieee80211_send_bar(struct ieee80211_vif *vif, u8 *ra, u16 tid, u16 ssn)



More information about the lede-commits mailing list