[openwrt/openwrt] base-files: disable LEDs if default state is undefined

LEDE Commits lede-commits at lists.infradead.org
Fri Sep 11 11:38:23 EDT 2020


blocktrron pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/e087bb5bd7d700c1de91395d62a3923e6305cc46

commit e087bb5bd7d700c1de91395d62a3923e6305cc46
Author: David Bauer <mail at david-bauer.net>
AuthorDate: Sun Jul 26 22:37:53 2020 +0200

    base-files: disable LEDs if default state is undefined
    
    Set the default state for LEDs to off. When a trigger is set, the
    trigger will turn the LED automatically on.
    
    Currently LEDs might stay on, e.g. when the LED trigger is set to a
    netdev trigger and the interface is never activated or the 'none'
    trigger is selected without setting the 'default' option to 0 and it's
    set for the LED indicating the system running state.
    
    Using off as a default value is also consistent with the documentation
    in the OpenWrt wiki.
    
    Signed-off-by: David Bauer <mail at david-bauer.net>
---
 package/base-files/Makefile             | 2 +-
 package/base-files/files/etc/init.d/led | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/base-files/Makefile b/package/base-files/Makefile
index 2419849a44..73455174db 100644
--- a/package/base-files/Makefile
+++ b/package/base-files/Makefile
@@ -12,7 +12,7 @@ include $(INCLUDE_DIR)/version.mk
 include $(INCLUDE_DIR)/feeds.mk
 
 PKG_NAME:=base-files
-PKG_RELEASE:=228
+PKG_RELEASE:=229
 PKG_FLAGS:=nonshared
 
 PKG_FILE_DEPENDS:=$(PLATFORM_DIR)/ $(GENERIC_PLATFORM_DIR)/base-files/
diff --git a/package/base-files/files/etc/init.d/led b/package/base-files/files/etc/init.d/led
index 932a69a82b..277fb4e76f 100755
--- a/package/base-files/files/etc/init.d/led
+++ b/package/base-files/files/etc/init.d/led
@@ -21,7 +21,7 @@ load_led() {
 	config_get dev $1 dev
 	config_get ports $1 port
 	config_get mode $1 mode
-	config_get_bool default $1 default "nil"
+	config_get_bool default $1 default "0"
 	config_get delayon $1 delayon
 	config_get delayoff $1 delayoff
 	config_get interval $1 interval "50"



More information about the lede-commits mailing list