[openwrt/openwrt] openvpn: fix shell compare operator in openvpn.init

LEDE Commits lede-commits at lists.infradead.org
Wed Sep 9 08:15:50 EDT 2020


adrian pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/d6235f48f8b343dde76c16b85285766089304e5e

commit d6235f48f8b343dde76c16b85285766089304e5e
Author: Martin Schiller <ms at dev.tdt.de>
AuthorDate: Wed Jun 24 07:22:17 2020 +0200

    openvpn: fix shell compare operator in openvpn.init
    
    Don't use bash syntax, because /bin/sh is used here.
    
    Signed-off-by: Martin Schiller <ms at dev.tdt.de>
    [bump PKG_RELEASE]
    Signed-off-by: Adrian Schmutzler <freifunk at adrianschmutzler.de>
---
 package/network/services/openvpn/Makefile           | 2 +-
 package/network/services/openvpn/files/openvpn.init | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/network/services/openvpn/Makefile b/package/network/services/openvpn/Makefile
index 9482e9ce39..40570fbdb6 100644
--- a/package/network/services/openvpn/Makefile
+++ b/package/network/services/openvpn/Makefile
@@ -10,7 +10,7 @@ include $(TOPDIR)/rules.mk
 PKG_NAME:=openvpn
 
 PKG_VERSION:=2.4.9
-PKG_RELEASE:=4
+PKG_RELEASE:=5
 
 PKG_SOURCE_URL:=\
 	https://build.openvpn.net/downloads/releases/ \
diff --git a/package/network/services/openvpn/files/openvpn.init b/package/network/services/openvpn/files/openvpn.init
index a454eb4ba0..487a2269e2 100644
--- a/package/network/services/openvpn/files/openvpn.init
+++ b/package/network/services/openvpn/files/openvpn.init
@@ -43,7 +43,7 @@ append_params() {
 		IFS="$LIST_SEP"
 		for v in $v; do
 			[ -n "$v" ] && [ "$p" != "push" ] && append_param "$s" "$p" && echo " $v" >> "/var/etc/openvpn-$s.conf"
-			[ -n "$v" ] && [ "$p" == "push" ] && append_param "$s" "$p" && echo " \"$v\"" >> "/var/etc/openvpn-$s.conf"
+			[ -n "$v" ] && [ "$p" = "push" ] && append_param "$s" "$p" && echo " \"$v\"" >> "/var/etc/openvpn-$s.conf"
 		done
 		unset IFS
 	done



More information about the lede-commits mailing list