[openwrt/openwrt] build: detect broken make version on macOS

LEDE Commits lede-commits at lists.infradead.org
Sat Nov 14 09:22:18 EST 2020


nbd pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/31043704558efdeb25e2be9b03f211513047c635

commit 31043704558efdeb25e2be9b03f211513047c635
Author: Felix Fietkau <nbd at nbd.name>
AuthorDate: Sat Nov 14 12:37:39 2020 +0100

    build: detect broken make version on macOS
    
    Apple ships a broken make version with the Xcode command line tools.
    Homebrew installs make as gmake by default in order to not collide with
    Apple's version.
    Exit with an error if the broken one is used accidentally
    
    Signed-off-by: Felix Fietkau <nbd at nbd.name>
---
 include/toplevel.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/include/toplevel.mk b/include/toplevel.mk
index c233a4c214..4003b48241 100644
--- a/include/toplevel.mk
+++ b/include/toplevel.mk
@@ -29,6 +29,12 @@ export GNU_HOST_NAME:=$(shell $(TOPDIR)/scripts/config.guess)
 export HOST_OS:=$(shell uname)
 export HOST_ARCH:=$(shell uname -m)
 
+ifeq ($(HOST_OS),Darwin)
+  ifneq ($(filter /Applications/Xcode.app/% /Library/Developer/%,$(MAKE)),)
+    $(error Please use a newer version of GNU make. The version shipped by Apple is not supported)
+  endif
+endif
+
 # prevent perforce from messing with the patch utility
 unexport P4PORT P4USER P4CONFIG P4CLIENT
 



More information about the lede-commits mailing list