[openwrt/openwrt] scripts/mkits.sh: fix use of printf

LEDE Commits lede-commits at lists.infradead.org
Sat Jul 11 12:48:43 EDT 2020


adrian pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/52cdd6185ec3320fe58de992c4a1750794082bfd

commit 52cdd6185ec3320fe58de992c4a1750794082bfd
Author: Adrian Schmutzler <freifunk at adrianschmutzler.de>
AuthorDate: Sat Jul 11 18:46:53 2020 +0200

    scripts/mkits.sh: fix use of printf
    
    Due to a line break, printf was accidentally called with three
    arguments instead of two, causing a different output than before.
    
    Fix it by splitting the printf command into two lines.
    
    Fixes: 907053193a1c ("scripts/mkits.sh: replace echo -e with printf")
    
    Signed-off-by: Adrian Schmutzler <freifunk at adrianschmutzler.de>
---
 scripts/mkits.sh | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/scripts/mkits.sh b/scripts/mkits.sh
index 65071e13ee..468ef670e6 100755
--- a/scripts/mkits.sh
+++ b/scripts/mkits.sh
@@ -15,8 +15,9 @@
 #
 
 usage() {
-	printf "Usage: %s -A arch -C comp -a addr -e entry -v version"\
-		 "-k kernel [-D name -d dtb] -o its_file" "$(basename "$0")"
+	printf "Usage: %s -A arch -C comp -a addr -e entry" "$(basename "$0")"
+	printf " -v version -k kernel [-D name -d dtb] -o its_file"
+
 	printf "\n\t-A ==> set architecture to 'arch'"
 	printf "\n\t-C ==> set compression type 'comp'"
 	printf "\n\t-c ==> set config name 'config'"



More information about the lede-commits mailing list