[openwrt/openwrt] ipq40xx: net: ethernet: edma: use generic PHY print

LEDE Commits lede-commits at lists.infradead.org
Wed Dec 23 10:36:36 EST 2020


ynezz pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/fd033364f655f129b438fe67c87f95ef7b56fda1

commit fd033364f655f129b438fe67c87f95ef7b56fda1
Author: Robert Marko <robert.marko at sartura.hr>
AuthorDate: Thu Nov 26 13:54:34 2020 +0100

    ipq40xx: net: ethernet: edma: use generic PHY print
    
    Lets use the generic upstream phy_print_status() instead of doing
    something similar by hand.
    
    Before:
    ess_edma c080000.edma: eth1: GMAC Link is up with phy_speed=1000
    
    After:
    ess_edma c080000.edma eth1: Link is Up - 1Gbps/Full - flow control rx/tx
    
    Signed-off-by: Robert Marko <robert.marko at sartura.hr>
---
 .../linux/ipq40xx/files/drivers/net/ethernet/qualcomm/essedma/edma.c  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/linux/ipq40xx/files/drivers/net/ethernet/qualcomm/essedma/edma.c b/target/linux/ipq40xx/files/drivers/net/ethernet/qualcomm/essedma/edma.c
index ecbc946de9..80db1f0acb 100644
--- a/target/linux/ipq40xx/files/drivers/net/ethernet/qualcomm/essedma/edma.c
+++ b/target/linux/ipq40xx/files/drivers/net/ethernet/qualcomm/essedma/edma.c
@@ -1310,7 +1310,7 @@ void edma_adjust_link(struct net_device *netdev)
 	status = edma_check_link(adapter);
 
 	if (status == __EDMA_LINKUP && adapter->link_state == __EDMA_LINKDOWN) {
-		dev_info(&adapter->pdev->dev, "%s: GMAC Link is up with phy_speed=%d\n", netdev->name, phydev->speed);
+		phy_print_status(phydev);
 		adapter->link_state = __EDMA_LINKUP;
 		if (adapter->edma_cinfo->is_single_phy) {
 			ess_set_port_status_speed(adapter->edma_cinfo, phydev,
@@ -1320,7 +1320,7 @@ void edma_adjust_link(struct net_device *netdev)
 		if (netif_running(netdev))
 			netif_tx_wake_all_queues(netdev);
 	} else if (status == __EDMA_LINKDOWN && adapter->link_state == __EDMA_LINKUP) {
-		dev_info(&adapter->pdev->dev, "%s: GMAC Link is down\n", netdev->name);
+		phy_print_status(phydev);
 		adapter->link_state = __EDMA_LINKDOWN;
 		netif_carrier_off(netdev);
 		netif_tx_stop_all_queues(netdev);



More information about the lede-commits mailing list