[openwrt/openwrt] apm821xx: tidy up 10-fix-wifi-mac

LEDE Commits lede-commits at lists.infradead.org
Mon Aug 17 17:21:49 EDT 2020


adrian pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/1a75443964558e67a29fac28ded9a15dbb715034

commit 1a75443964558e67a29fac28ded9a15dbb715034
Author: Adrian Schmutzler <freifunk at adrianschmutzler.de>
AuthorDate: Mon Aug 17 23:09:37 2020 +0200

    apm821xx: tidy up 10-fix-wifi-mac
    
    This applies some cosmetic style fixes:
    - remove useless echo
    - remove double equal sign (specific to bash)
    - add quotes for -n check
    
    Signed-off-by: Adrian Schmutzler <freifunk at adrianschmutzler.de>
---
 .../apm821xx/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac     | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/target/linux/apm821xx/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac b/target/linux/apm821xx/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac
index 597b5dcca6..a78a1054f1 100644
--- a/target/linux/apm821xx/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac
+++ b/target/linux/apm821xx/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac
@@ -1,10 +1,10 @@
 #!/bin/ash
 
-[ "$ACTION" == "add" ] || exit 0
+[ "$ACTION" = "add" ] || exit 0
 
 PHYNBR=${DEVPATH##*/phy}
 
-[ -n $PHYNBR ] || exit 0
+[ -n "$PHYNBR" ] || exit 0
 
 . /lib/functions.sh
 . /lib/functions/system.sh
@@ -14,7 +14,7 @@ board=$(board_name)
 case "$board" in
 netgear,wndap620|\
 netgear,wndap660)
-	echo $(macaddr_add $(mtd_get_mac_ascii u-boot-env baseMAC) $(($PHYNBR + 1)) ) > /sys${DEVPATH}/macaddress
+	macaddr_add $(mtd_get_mac_ascii u-boot-env baseMAC) $(($PHYNBR + 1)) > /sys${DEVPATH}/macaddress
 	;;
 *)
 	;;



More information about the lede-commits mailing list