[openwrt/openwrt] mpc85xx: tidy up 10-fix-wifi-mac

LEDE Commits lede-commits at lists.infradead.org
Thu Aug 13 14:29:49 EDT 2020


adrian pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/488da882f5102e4283b4864e6180c2c7fb8f494a

commit 488da882f5102e4283b4864e6180c2c7fb8f494a
Author: Adrian Schmutzler <freifunk at adrianschmutzler.de>
AuthorDate: Thu Aug 13 20:22:30 2020 +0200

    mpc85xx: tidy up 10-fix-wifi-mac
    
    This applies some cosmetic style fixes, mostly by removing useless
    echo commands.
    
    Signed-off-by: Adrian Schmutzler <freifunk at adrianschmutzler.de>
---
 .../base-files/etc/hotplug.d/ieee80211/10-fix-wifi-mac     | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/target/linux/mpc85xx/base-files/etc/hotplug.d/ieee80211/10-fix-wifi-mac b/target/linux/mpc85xx/base-files/etc/hotplug.d/ieee80211/10-fix-wifi-mac
index cd829cb471..c6cede3a1f 100644
--- a/target/linux/mpc85xx/base-files/etc/hotplug.d/ieee80211/10-fix-wifi-mac
+++ b/target/linux/mpc85xx/base-files/etc/hotplug.d/ieee80211/10-fix-wifi-mac
@@ -1,10 +1,10 @@
 #!/bin/ash
 
-[ "$ACTION" == "add" ] || exit 0
+[ "$ACTION" = "add" ] || exit 0
 
 PHYNBR=${DEVPATH##*/phy}
 
-[ -n $PHYNBR ] || exit 0
+[ -n "$PHYNBR" ] || exit 0
 
 . /lib/functions.sh
 . /lib/functions/system.sh
@@ -13,16 +13,12 @@ board=$(board_name)
 
 case "$board" in
 enterasys,ws-ap3710i)
-	echo $(mtd_get_mac_ascii cfg2 RADIOADDR${PHYNBR}) > /sys${DEVPATH}/macaddress
+	mtd_get_mac_ascii cfg2 RADIOADDR${PHYNBR} > /sys${DEVPATH}/macaddress
 	;;
 ocedo,panda)
-	WMAC=wmac$(($PHYNBR + 1))
-	MAC=$(mtd_get_mac_ascii uboot-env0 ${WMAC})
-	echo ${MAC} > /sys${DEVPATH}/macaddress
+	mtd_get_mac_ascii uboot-env0 wmac$(($PHYNBR + 1)) > /sys${DEVPATH}/macaddress
 	;;
 sophos,red-15w-rev1)
-	echo $(mtd_get_mac_ascii u-boot-env ethaddr) > /sys${DEVPATH}/macaddress
-	;;
-*)
+	mtd_get_mac_ascii u-boot-env ethaddr > /sys${DEVPATH}/macaddress
 	;;
 esac



More information about the lede-commits mailing list