[openwrt/openwrt] Revert "ar71xx: fix Arduino Yun enabling of level shifters outputs"

LEDE Commits lede-commits at lists.infradead.org
Sun Aug 2 10:35:22 EDT 2020


adrian pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/43896dc0b005adfb512c027a27781c971440d415

commit 43896dc0b005adfb512c027a27781c971440d415
Author: Sungbo Eo <mans0n at gorani.run>
AuthorDate: Sun Jan 12 21:33:53 2020 +0900

    Revert "ar71xx: fix Arduino Yun enabling of level shifters outputs"
    
    This reverts commit 077253dd666a30ae5231c3748222d4b5b138593d.
    
    The output enable pins should be disabled by default, and only enabled when
    used. Otherwise unwanted conflicts might occur between MCU and SoC pins.
    
    Signed-off-by: Sungbo Eo <mans0n at gorani.run>
---
 target/linux/ar71xx/files/arch/mips/ath79/mach-arduino-yun.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-arduino-yun.c b/target/linux/ar71xx/files/arch/mips/ath79/mach-arduino-yun.c
index e92f68f490..5873248edf 100644
--- a/target/linux/ar71xx/files/arch/mips/ath79/mach-arduino-yun.c
+++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-arduino-yun.c
@@ -141,7 +141,7 @@ static void __init ds_setup(void)
 
 	// enable OE of level shifter
 	if (gpio_request_one(DS_GPIO_OE,
-	    GPIOF_OUT_INIT_HIGH | GPIOF_EXPORT_DIR_FIXED, "OE-1") != 0)
+	    GPIOF_OUT_INIT_LOW | GPIOF_EXPORT_DIR_FIXED, "OE-1") != 0)
 		printk("Error setting GPIO OE\n");
 
 	if (gpio_request_one(DS_GPIO_UART_ENA,
@@ -150,7 +150,7 @@ static void __init ds_setup(void)
 
 	// enable OE of level shifter
 	if (gpio_request_one(DS_GPIO_OE2,
-	    GPIOF_OUT_INIT_HIGH | GPIOF_EXPORT_DIR_FIXED, "OE-2") != 0)
+	    GPIOF_OUT_INIT_LOW | GPIOF_EXPORT_DIR_FIXED, "OE-2") != 0)
 		printk("Error setting GPIO OE2\n");
 }
 



More information about the lede-commits mailing list