[openwrt/openwrt] ipq40xx: Use constant to set gpio active low/high

LEDE Commits lede-commits at lists.infradead.org
Fri Mar 23 12:44:53 PDT 2018


mkresin pushed a commit to openwrt/openwrt.git, branch master:
https://git.lede-project.org/9ca81646b9235f8963c5264f15597a9b61c029d4

commit 9ca81646b9235f8963c5264f15597a9b61c029d4
Author: Sven Eckelmann <sven.eckelmann at openmesh.com>
AuthorDate: Mon Mar 19 14:52:38 2018 +0100

    ipq40xx: Use constant to set gpio active low/high
    
    The GPIO configuration in the DTS have as third parameter the active
    low/high configuration. This parameter is not easy to parse by humans when
    it is only set to 0/1. It is better to use the predefined constants
    GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW.
    
    Signed-off-by: Sven Eckelmann <sven.eckelmann at openmesh.com>
---
 .../linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-a42.dts   | 2 +-
 .../ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-rt-ac58u.dts    | 4 ++--
 .../ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi  | 3 ++-
 .../ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-fritz4040.dts   | 2 +-
 .../ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4028-wpj428.dts      | 2 +-
 .../ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-gl-b1300.dts    | 2 +-
 .../linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-mr33.dts  | 2 +-
 7 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-a42.dts b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-a42.dts
index 1ccd9f9..222d39b 100644
--- a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-a42.dts
+++ b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-a42.dts
@@ -190,7 +190,7 @@
 	pinctrl-0 = <&spi_0_pins>;
 	pinctrl-names = "default";
 	status = "okay";
-	cs-gpios = <&tlmm 54 0>;
+	cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
 
 	m25p80 at 0 {
 		#address-cells = <1>;
diff --git a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-rt-ac58u.dts b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-rt-ac58u.dts
index 2b40b9e..446da04 100644
--- a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-rt-ac58u.dts
+++ b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-rt-ac58u.dts
@@ -216,8 +216,8 @@
 	pinctrl-0 = <&spi_0_pins>;
 	pinctrl-names = "default";
 	status = "okay";
-	cs-gpios = <&tlmm 54 0>,
-		   <&tlmm 59 0>;
+	cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>,
+		   <&tlmm 59 GPIO_ACTIVE_HIGH>;
 
 	m25p80 at 0 {
 		#address-cells = <1>;
diff --git a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi
index 753adf9..eeadc07 100644
--- a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi
+++ b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi
@@ -15,6 +15,7 @@
  */
 
 #include "qcom-ipq4019.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK04.1";
@@ -101,7 +102,7 @@
 			pinctrl-0 = <&spi_0_pins>;
 			pinctrl-names = "default";
 			status = "okay";
-			cs-gpios = <&tlmm 12 0>;
+			cs-gpios = <&tlmm 12 GPIO_ACTIVE_HIGH>;
 
 			mx25l25635e at 0 {
 				#address-cells = <1>;
diff --git a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-fritz4040.dts b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-fritz4040.dts
index 65e802b..4b5cbca 100644
--- a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-fritz4040.dts
+++ b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-fritz4040.dts
@@ -225,7 +225,7 @@
 	pinctrl-0 = <&spi_0_pins>;
 	pinctrl-names = "default";
 	status = "okay";
-	cs-gpios = <&tlmm 54 0>;
+	cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
 
 	mx25l25635f at 0 {
 		compatible = "jedec,spi-nor";
diff --git a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4028-wpj428.dts b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4028-wpj428.dts
index 746b289..f9f0f96 100644
--- a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4028-wpj428.dts
+++ b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4028-wpj428.dts
@@ -167,7 +167,7 @@
 	pinctrl-0 = <&spi_0_pins>;
 	pinctrl-names = "default";
 	status = "okay";
-	cs-gpios = <&tlmm 54 0>;
+	cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
 
 	m25p80 at 0 {
 		#address-cells = <1>;
diff --git a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-gl-b1300.dts b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-gl-b1300.dts
index f3db47f..c4b002b 100644
--- a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-gl-b1300.dts
+++ b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-gl-b1300.dts
@@ -193,7 +193,7 @@
 	pinctrl-0 = <&spi_0_pins>;
 	pinctrl-names = "default";
 	status = "okay";
-	cs-gpios = <&tlmm 54 0>;
+	cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
 
 	mx25l25635f at 0 {
 		compatible = "jedec,spi-nor";
diff --git a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-mr33.dts b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-mr33.dts
index 9c1ef4f..ef62301 100644
--- a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-mr33.dts
+++ b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-mr33.dts
@@ -60,7 +60,7 @@
 			status = "okay";
 			pinctrl-0 = <&mdio_pins>;
 			pinctrl-names = "default";
-			phy-reset-gpio = <&tlmm 47 0>;
+			phy-reset-gpio = <&tlmm 47 GPIO_ACTIVE_HIGH>;
 			/delete-node/ ethernet-phy at 0;
 			/delete-node/ ethernet-phy at 2;
 			/delete-node/ ethernet-phy at 3;



More information about the lede-commits mailing list