[openwrt/openwrt] generic: revert broken LED core patch

LEDE Commits lede-commits at lists.infradead.org
Thu Mar 8 13:30:19 PST 2018


neoraider pushed a commit to openwrt/openwrt.git, branch lede-17.01:
https://git.lede-project.org/9bdea6a2964b9983d312b302e0fdde98c6bdc53b

commit 9bdea6a2964b9983d312b302e0fdde98c6bdc53b
Author: Matthias Schiffer <mschiffer at universe-factory.net>
AuthorDate: Thu Mar 8 22:23:57 2018 +0100

    generic: revert broken LED core patch
    
    At least on some devices, LEDs don't work anymore since kernel 4.4.120.
    Revert the broken change.
    
    See also: https://www.spinics.net/lists/stable/msg223656.html
    
    Signed-off-by: Matthias Schiffer <mschiffer at universe-factory.net>
---
 ...core-Fix-brightness-setting-when-setting-.patch | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/target/linux/generic/patches-4.4/087-Revert-led-core-Fix-brightness-setting-when-setting-.patch b/target/linux/generic/patches-4.4/087-Revert-led-core-Fix-brightness-setting-when-setting-.patch
new file mode 100644
index 0000000..6378ed4
--- /dev/null
+++ b/target/linux/generic/patches-4.4/087-Revert-led-core-Fix-brightness-setting-when-setting-.patch
@@ -0,0 +1,28 @@
+From 4b98deaa353d8f7af3f7543d0b59497fe1275599 Mon Sep 17 00:00:00 2001
+Message-Id: <4b98deaa353d8f7af3f7543d0b59497fe1275599.1520544136.git.mschiffer at universe-factory.net>
+From: Matthias Schiffer <mschiffer at universe-factory.net>
+Date: Thu, 8 Mar 2018 22:22:08 +0100
+Subject: [PATCH] Revert "led: core: Fix brightness setting when setting
+ delay_off=0"
+
+This reverts commit 20ac8f72514b3af8b62c520d55656ded865eff00.
+---
+ drivers/leds/led-core.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c
+index 92b6798ef5b3..c1c3af089634 100644
+--- a/drivers/leds/led-core.c
++++ b/drivers/leds/led-core.c
+@@ -149,7 +149,7 @@ void led_blink_set(struct led_classdev *led_cdev,
+ 		   unsigned long *delay_on,
+ 		   unsigned long *delay_off)
+ {
+-	led_stop_software_blink(led_cdev);
++	del_timer_sync(&led_cdev->blink_timer);
+ 
+ 	led_cdev->flags &= ~LED_BLINK_ONESHOT;
+ 	led_cdev->flags &= ~LED_BLINK_ONESHOT_STOP;
+-- 
+2.16.2
+



More information about the lede-commits mailing list