[openwrt/openwrt] scripts/package-metadata.pl: remove broken detection of self-dependencies
LEDE Commits
lede-commits at lists.infradead.org
Thu Jan 4 08:24:03 PST 2018
neoraider pushed a commit to openwrt/openwrt.git, branch master:
https://git.lede-project.org/0b28cc56d4352f5a8b2e7783d3787e6effcdb630
commit 0b28cc56d4352f5a8b2e7783d3787e6effcdb630
Author: Matthias Schiffer <mschiffer at universe-factory.net>
AuthorDate: Thu Jan 4 17:18:16 2018 +0100
scripts/package-metadata.pl: remove broken detection of self-dependencies
A self-dependency is not an error worth a warning; rather, it is very
common: whenever there are dependencies between different binary packages
originating from the same source package, such dependencies occur. Not
actually generating dependency rules is correct, but already handled a few
lines below.
A typo prevented this redundant rule from working, which is the reason the
warning was not actually printed.
Signed-off-by: Matthias Schiffer <mschiffer at universe-factory.net>
---
scripts/package-metadata.pl | 5 -----
1 file changed, 5 deletions(-)
diff --git a/scripts/package-metadata.pl b/scripts/package-metadata.pl
index 261490b..fbd458b 100755
--- a/scripts/package-metadata.pl
+++ b/scripts/package-metadata.pl
@@ -535,11 +535,6 @@ sub gen_package_mk() {
$pkg->{makefile}, $pkg_dep->{src}, $deptype, $pkg_dep->{makefile}, $deptype;
next;
}
- unless ($pkg->{src} ne $pkg_dep->{sec}.$suffix) {
- warn sprintf "WARNING: Makefile '%s' has a build dependency on itself\n",
- $pkg->{makefile};
- next;
- }
$idx = $pkg_dep->{subdir}.$pkg_dep->{src};
} elsif (defined($srcpackage{$dep})) {
$idx = $subdir{$dep}.$dep;
More information about the lede-commits
mailing list